All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	sakato <ryusuke.sakato.bx@renesas.com>,
	OSD2 ML <osd2@lm.renesas.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()
Date: Thu, 26 May 2016 21:04:15 +0530	[thread overview]
Message-ID: <20160526153414.GV2735@localhost> (raw)
In-Reply-To: <2831766.dEtRrr4FvR@avalon>

On Tue, May 24, 2016 at 12:50:28PM +0300, Laurent Pinchart wrote:

Hey Laurent,

> On Saturday 14 May 2016 13:27:31 Vinod Koul wrote:
> > On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > > push used descriptor to list of free descriptors, and next DMA transfer
> > > try to reuse it from this list. But because it is using *_tail(),
> > > this reuse effect can't be obtained without using all of them.
> > > For a longer-term solution, we should allocate hardware descriptors
> > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > > This patch uses list_add() instead of list_add_tail() for short-term
> > > solution.
> > 
> > Applied, thanks
> 
> Thanks, but where did you apply it to ? I can't find it in your tree.

I changed my mind after this and felt that we should document above
in the changelog as well and replied to Kuninori few moments after this [1]

Sorry if that wasn't clear that am not applying this.

Please resend it with update changelog

[1]: http://www.spinics.net/lists/dmaengine/msg09585.html

-- 
~Vinod

  reply	other threads:[~2016-05-26 15:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.journal-676557.20160325074450.6aeff6eaa5fae69d@dm.renesas.com>
     [not found] ` <8760w7xq3n.wl%kuninori.morimoto.gx@renesas.com>
     [not found]   ` <874mbrxnft.wl%kuninori.morimoto.gx@renesas.com>
     [not found]     ` <1645988.6VIRltF7C5@avalon>
2016-04-22  1:50       ` [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put() Kuninori Morimoto
2016-05-02  9:37         ` Vinod Koul
2016-05-09 20:49           ` Laurent Pinchart
2016-05-11  3:28             ` Kuninori Morimoto
2016-05-14  8:11               ` Vinod Koul
2016-05-14  7:57         ` Vinod Koul
2016-05-24  9:50           ` Laurent Pinchart
2016-05-26 15:34             ` Vinod Koul [this message]
2016-05-30  0:34               ` Kuninori Morimoto
2016-05-30  0:41       ` [PATCH v2] " Kuninori Morimoto
2016-05-30  3:42         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526153414.GV2735@localhost \
    --to=vinod.koul@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osd2@lm.renesas.com \
    --cc=ryusuke.sakato.bx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.