From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Date: Thu, 26 May 2016 16:45:57 +0000 Subject: Re: [PATCH 0/4] sh: fix up modular use in non-modular code Message-Id: <20160526164557.GJ27984@windriver.com> List-Id: References: <1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Rich Felker , Yoshinori Sato [[PATCH 0/4] sh: fix up modular use in non-modular code] On 22/04/2016 (Fri 14:07) Paul Gortmaker wrote: > For anyone new to the underlying goal of this cleanup, we are trying to > make kernel code consistent with the Makefiles/Kconfigs that control them. Ping -- wondering if there are any issues here, or if I can expect these to be merged upstream in the merge window. I didn't see them loop around via the linux-next tree but I wasn't sure if arch/sh has a repo for linux-next. Thanks, Paul. -- > > This means not using modular functions/macros for code that can never > be built as a module. Some of the other downfalls this leads to are: > > (1) it is easy to accidentally write unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else, thus adding to CPP overhead. > (4) it gets copied/replicated into other drivers and spreads like weeds. > > Three of the four commits here are completely trivial with zero runtime > impact whatsoever. The fourth has a deletion of a ".remove" function > and as we've done elsewhere, we block the sysfs ability to reach in and > manually execute that function, since there isn't a sane use case for > which doing that makes sense. > > Build tested on today's linux-next ; full build fails on duplicate syms > from OF generic board, but that is a known and reported issue elsewhere; > it has nothing to do with the changes here. > > Paul > -- > > Cc: linux-sh@vger.kernel.org > Cc: Paul Gortmaker > Cc: Rich Felker > Cc: Yoshinori Sato > > > Paul Gortmaker (4): > sh: make time.c explicitly non-modular > sh: make mm/asids-debugfs explicitly non-modular > sh: make board-secureedge5410 explicitly non-modular > sh: make heartbeat driver explicitly non-modular > > arch/sh/boards/board-secureedge5410.c | 3 +-- > arch/sh/drivers/heartbeat.c | 32 +++----------------------------- > arch/sh/kernel/time.c | 3 +-- > arch/sh/mm/asids-debugfs.c | 5 +---- > 4 files changed, 6 insertions(+), 37 deletions(-) > > -- > 2.8.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbcEZQqR (ORCPT ); Thu, 26 May 2016 12:46:17 -0400 Received: from mail1.windriver.com ([147.11.146.13]:65169 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcEZQqQ (ORCPT ); Thu, 26 May 2016 12:46:16 -0400 Date: Thu, 26 May 2016 12:45:57 -0400 From: Paul Gortmaker To: , , Rich Felker , Yoshinori Sato Subject: Re: [PATCH 0/4] sh: fix up modular use in non-modular code Message-ID: <20160526164557.GJ27984@windriver.com> References: <1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [[PATCH 0/4] sh: fix up modular use in non-modular code] On 22/04/2016 (Fri 14:07) Paul Gortmaker wrote: > For anyone new to the underlying goal of this cleanup, we are trying to > make kernel code consistent with the Makefiles/Kconfigs that control them. Ping -- wondering if there are any issues here, or if I can expect these to be merged upstream in the merge window. I didn't see them loop around via the linux-next tree but I wasn't sure if arch/sh has a repo for linux-next. Thanks, Paul. -- > > This means not using modular functions/macros for code that can never > be built as a module. Some of the other downfalls this leads to are: > > (1) it is easy to accidentally write unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else, thus adding to CPP overhead. > (4) it gets copied/replicated into other drivers and spreads like weeds. > > Three of the four commits here are completely trivial with zero runtime > impact whatsoever. The fourth has a deletion of a ".remove" function > and as we've done elsewhere, we block the sysfs ability to reach in and > manually execute that function, since there isn't a sane use case for > which doing that makes sense. > > Build tested on today's linux-next ; full build fails on duplicate syms > from OF generic board, but that is a known and reported issue elsewhere; > it has nothing to do with the changes here. > > Paul > -- > > Cc: linux-sh@vger.kernel.org > Cc: Paul Gortmaker > Cc: Rich Felker > Cc: Yoshinori Sato > > > Paul Gortmaker (4): > sh: make time.c explicitly non-modular > sh: make mm/asids-debugfs explicitly non-modular > sh: make board-secureedge5410 explicitly non-modular > sh: make heartbeat driver explicitly non-modular > > arch/sh/boards/board-secureedge5410.c | 3 +-- > arch/sh/drivers/heartbeat.c | 32 +++----------------------------- > arch/sh/kernel/time.c | 3 +-- > arch/sh/mm/asids-debugfs.c | 5 +---- > 4 files changed, 6 insertions(+), 37 deletions(-) > > -- > 2.8.0 >