From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Lieven <pl@kamp.de>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests
Date: Fri, 27 May 2016 08:36:02 +0800 [thread overview]
Message-ID: <20160527003602.GG31052@ad.usersys.redhat.com> (raw)
In-Reply-To: <4b26422f-9320-31a6-9dca-534bf0ea6086@redhat.com>
On Thu, 05/26 11:20, Paolo Bonzini wrote:
>
>
> On 26/05/2016 10:30, Fam Zheng wrote:
> >> >
> >> > This doesn't look too wrong... Should the right sequence of events be
> >> > head/after_head or head/after_tail? It's probably simplest to just emit
> >> > all four events.
> > I've no idea. (That's why I leaned towards fixing the test case).
>
> Well, fixing the testcase means knowing what events should be emitted.
>
> QEMU with Peter's patch emits head/after_head. If the right one is
> head/after_tail, _both QEMU and the testcase_ need to be adjusted. Your
> patch keeps the backwards-compatible route.
Yes, I mean I was not very convinced in tweaking the events at all: each pair
of them has been emitted around bdrv_aligned_preadv(), and the new branch
doesn't do it anymore. So I don't see a reason to add events here.
Fam
next prev parent reply other threads:[~2016-05-27 0:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:30 [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests Peter Lieven
2016-05-24 15:07 ` Kevin Wolf
2016-05-26 6:50 ` Fam Zheng
2016-05-26 7:10 ` Fam Zheng
2016-05-26 7:55 ` Paolo Bonzini
2016-05-26 8:30 ` Fam Zheng
2016-05-26 9:20 ` Paolo Bonzini
2016-05-27 0:36 ` Fam Zheng [this message]
2016-05-27 8:55 ` Kevin Wolf
2016-05-30 6:25 ` Peter Lieven
2016-05-30 8:24 ` Kevin Wolf
2016-05-30 9:30 ` Peter Lieven
2016-05-30 9:47 ` Kevin Wolf
2016-05-30 9:53 ` Peter Lieven
2016-05-30 10:06 ` Kevin Wolf
2016-05-30 10:10 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527003602.GG31052@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.