From: "J. Bruce Fields" <bfields@fieldses.org>
To: George Spelvin <linux@sciencehorizons.net>
Cc: linux@horizon.com, jlayton@poochiereds.net, linux-nfs@vger.kernel.org
Subject: Re: [PATCH RESEND 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string()
Date: Fri, 27 May 2016 08:16:32 -0400 [thread overview]
Message-ID: <20160527121632.GC25272@fieldses.org> (raw)
In-Reply-To: <20160527032946.12751.qmail@ns.sciencehorizons.net>
On Thu, May 26, 2016 at 11:29:46PM -0400, George Spelvin wrote:
> Okay, it's now okay to re-pull. I renamed mine to hashlen_string(),
> since that's what it returns (the hash and the length), which both
> solves the problem,and is frankly a better name.
>
> Thank you for prodding me to wade through the GCC 6 warning
> spam. Thre were some problems hiding there.
>
> I discovered that adding #include <linux/bug.h> breaks the tools.perf
> build. It makes local copies of some kernel headers under control of
> a MANIFEST file, and I can't be arsed to figure it out.
>
> So I deleted the BUILD_BUG_ON entirely, and it's now (finally!) finished
> an allyesconfig build without any warnings that look new.
I also needed the following.
That still gets me some compiler warnings in gfs2, but looks like code
your patches don't touch, so that's probably a preexisting gfs2 problem.
But... the resulting kernel isn't booting succesfully for me. Not sure
what's up there, I'll investigate some more.
--b.
commit 5168cb717b37ef0b183dee9b411a85831b558b9b
Author: J. Bruce Fields <bfields@redhat.com>
Date: Fri May 27 07:10:21 2016 -0400
XXX
diff --git a/include/linux/hash.h b/include/linux/hash.h
index 1afde47..21b8ebc 100644
--- a/include/linux/hash.h
+++ b/include/linux/hash.h
@@ -15,6 +15,7 @@
*/
#include <asm/types.h>
+#include <linux/bug.h>
#include <linux/compiler.h>
/* 2^31 + 2^29 - 2^25 + 2^22 - 2^19 - 2^16 + 1 */
next prev parent reply other threads:[~2016-05-27 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160527003254.GA25272@fieldses.org>
2016-05-27 1:56 ` [PATCH RESEND 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string() George Spelvin
2016-05-27 3:29 ` George Spelvin
2016-05-27 12:16 ` J. Bruce Fields [this message]
2016-05-27 12:20 ` George Spelvin
2016-05-27 17:40 ` J. Bruce Fields
2016-05-27 21:25 ` George Spelvin
2016-05-27 17:14 ` I may be on the trail of that bug you hit George Spelvin
2016-05-25 7:26 [PATCH 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string() George Spelvin
2016-05-26 18:39 ` [PATCH RESEND " George Spelvin
2016-05-26 18:45 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527121632.GC25272@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@horizon.com \
--cc=linux@sciencehorizons.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.