From: Brian Norris <briannorris@chromium.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH] pwm: don't allow duty cycle higher than period
Date: Fri, 27 May 2016 09:50:37 -0700 [thread overview]
Message-ID: <20160527165037.GA112338@google.com> (raw)
In-Reply-To: <20160527163943.GB80118@google.com>
On Fri, May 27, 2016 at 09:39:43AM -0700, Brian Norris wrote:
> On Fri, May 27, 2016 at 06:38:14PM +0200, Boris Brezillon wrote:
> > On Fri, 27 May 2016 09:35:33 -0700
> > Brian Norris <briannorris@chromium.org> wrote:
> > > On Fri, May 27, 2016 at 09:34:39AM +0200, Boris Brezillon wrote:
> > > Now that you mention it, I think you've also dropped some signed
> > > (negative value) checking in pwm_config(). I'll squash in your diff +
> > > some pwm_config() fixes.
> >
> > ->period and ->duty_cycle are unsigned now ;).
>
> Not in pwm_config(). And we don't want to implitly make thos into large
I really can't spell today... two typos in the same sentence!
> unsigned values.
Brian
next prev parent reply other threads:[~2016-05-27 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 21:05 [PATCH] pwm: don't allow duty cycle higher than period Brian Norris
2016-05-26 21:05 ` Brian Norris
2016-05-27 7:34 ` Boris Brezillon
2016-05-27 7:34 ` Boris Brezillon
2016-05-27 16:35 ` Brian Norris
2016-05-27 16:38 ` Boris Brezillon
2016-05-27 16:39 ` Brian Norris
2016-05-27 16:50 ` Brian Norris [this message]
2016-05-27 16:40 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527165037.GA112338@google.com \
--to=briannorris@chromium.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.