All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>,
	James Feeney <james@nurealm.net>, Stable <stable@vger.kernel.org>
Subject: Re: rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01
Date: Fri, 27 May 2016 17:53:47 +0000 (UTC)	[thread overview]
Message-ID: <20160527175347.500B56126B@smtp.codeaurora.org> (raw)
In-Reply-To: <1463849435-2293-1-git-send-email-Larry.Finger@lwfinger.net>

Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Commit 49f86ec21c01 ("rtlwifi: Change long delays to sleeps") was correct
> for most cases; however, driver rtl8192ce calls the affected routines while
> in atomic context. The kernel bug output is as follows:
> 
> BUG: scheduling while atomic: wpa_supplicant/627/0x00000002
> [...]
>   [<ffffffff815c2b39>] __schedule+0x899/0xad0
>   [<ffffffff815c2dac>] schedule+0x3c/0x90
>   [<ffffffff815c5bb2>] schedule_hrtimeout_range_clock+0xa2/0x120
>   [<ffffffff810e8b80>] ? hrtimer_init+0x120/0x120
>   [<ffffffff815c5ba6>] ? schedule_hrtimeout_range_clock+0x96/0x120
>   [<ffffffff815c5c43>] schedule_hrtimeout_range+0x13/0x20
>   [<ffffffff815c568f>] usleep_range+0x4f/0x70
>   [<ffffffffa0667218>] rtl_rfreg_delay+0x38/0x50 [rtlwifi]
>   [<ffffffffa06dd0e7>] rtl92c_phy_config_rf_with_headerfile+0xc7/0xe0 [rtl8192ce]
> 
> To fix this bug, three of the changes from delay to sleep are reverted.
> Unfortunately, one of the changes involves a delay of 50 msec. The calling
> code will be modified so that this long delay can be avoided; however,
> this change is being pushed now to fix the problem in kernel 4.6.0.
> 
> Fixes: 49f86ec21c01 ("rtlwifi: Change long delays to sleeps")
> Reported-by: James Feeney <james@nurealm.net>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: James Feeney <james@nurealm.net>
> Cc: Stable <stable@vger.kernel.org> [4.6+]

Thanks, 1 patch applied to wireless-drivers.git:

de26859dcf36 rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9130617/


      parent reply	other threads:[~2016-05-27 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 16:50 [PATCH] rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01 Larry Finger
2016-05-22  5:53 ` Kalle Valo
2016-05-22 14:46   ` Larry Finger
2016-05-27 17:53 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160527175347.500B56126B@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=james@nurealm.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.