From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrzej Hajda <a.hajda@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
David Airlie <airlied@linux.ie>,
Robin Murphy <robin.murphy@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Bob Peterson <rpeterso@redhat.com>,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH] remove lots of IS_ERR_VALUE abuses
Date: Fri, 27 May 2016 23:04:58 +0100 [thread overview]
Message-ID: <20160527220458.GV14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1464384685-347275-1-git-send-email-arnd@arndb.de>
On Fri, May 27, 2016 at 11:23:25PM +0200, Arnd Bergmann wrote:
> @@ -837,7 +837,7 @@ static int load_flat_shared_library(int id, struct lib_info *libs)
>
> res = prepare_binprm(&bprm);
>
> - if (!IS_ERR_VALUE(res))
> + if (res >= 0)
if (res == 0), please - prepare_binprm() returns 0 or -E...
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -521,7 +521,7 @@ static int p9_check_errors(struct p9_client *c, struct p9_req_t *req)
> if (p9_is_proto_dotu(c))
> err = -ecode;
>
> - if (!err || !IS_ERR_VALUE(err)) {
> + if (!err || !IS_ERR_VALUE((unsigned long)err)) {
Not really - it's actually
if (p9_is_proto_dotu(c) && ecode < 512)
err = -ecode;
if (!err) {
...
> @@ -608,7 +608,7 @@ static int p9_check_zc_errors(struct p9_client *c, struct p9_req_t *req,
> if (p9_is_proto_dotu(c))
> err = -ecode;
>
> - if (!err || !IS_ERR_VALUE(err)) {
> + if (!err || !IS_ERR_VALUE((unsigned long)err)) {
Ditto.
next prev parent reply other threads:[~2016-05-27 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 21:23 [PATCH] remove lots of IS_ERR_VALUE abuses Arnd Bergmann
2016-05-27 22:02 ` Srinivas Kandagatla
2016-05-27 22:04 ` Al Viro [this message]
[not found] ` <1464384685-347275-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-05-27 21:46 ` Andrew Morton
2016-05-27 21:46 ` Andrew Morton
2016-05-27 21:56 ` Linus Torvalds
2016-05-27 23:24 ` Linus Torvalds
2016-05-27 23:24 ` Linus Torvalds
2016-05-27 23:24 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2016-07-06 19:17 [PATCH] Remove " Arvind Yadav
2016-07-07 8:10 ` Arnd Bergmann
2016-07-07 15:17 ` arvind Yadav
2016-07-07 15:17 ` arvind Yadav
2016-07-06 19:38 Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527220458.GV14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.hajda@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=rpeterso@redhat.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.