From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()
Date: Sat, 28 May 2016 04:46:18 +0000 [thread overview]
Message-ID: <20160528044618.GQ11011@mwanda> (raw)
In-Reply-To: <20160527112311.GC3255@mwanda>
On Fri, May 27, 2016 at 07:25:30PM +0200, walter harms wrote:
>
>
> Am 27.05.2016 14:23, schrieb Michal Nazarewicz:
> > On Fri, May 27 2016, Dan Carpenter wrote:
> >> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> >> index 73515d5..7fff81a 100644
> >> --- a/drivers/usb/gadget/function/f_fs.c
> >> +++ b/drivers/usb/gadget/function/f_fs.c
> >> @@ -2777,11 +2777,11 @@ static int _ffs_func_bind(struct usb_configuration *c,
> >> ffs->raw_descs_length);
> >>
> >> memset(vla_ptr(vlabuf, d, inums), 0xff, d_inums__sz);
> >> - for (ret = ffs->eps_count; ret; --ret) {
> >> + for (i = 0; i < ffs->eps_count; i++) {
> >> struct ffs_ep *ptr;
> >>
> >> ptr = vla_ptr(vlabuf, d, eps);
> >
> > As pointed by Walter, this could be moved outside. Maybe
> >
> > i = ffs->eps_count;
> > for (struct ffs_ep *ptr = vla_ptr(vlabuf, d, eps); i; ++ptr, --i)
> > ptr->num = -1;
> >
>
> I think staying with an array here improves readability.
>
I'm surprised you didn't comment on the --i. I was thinking about you
when I changed it to a ++ loop. Also in the kernel we have to declare
variables at the start of the block.
Anyway, let me send a v2.
regards,
dan carpenter
next prev parent reply other threads:[~2016-05-28 4:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:23 [patch] usb: f_fs: off by one bug in _ffs_func_bind() Dan Carpenter
2016-05-27 11:45 ` walter harms
2016-05-27 12:23 ` Michal Nazarewicz
2016-05-27 17:25 ` walter harms
2016-05-28 4:46 ` Dan Carpenter [this message]
2016-05-28 4:48 ` [patch v2] " Dan Carpenter
2016-05-28 4:48 ` Dan Carpenter
2016-05-28 9:05 ` walter harms
2016-05-28 9:05 ` walter harms
2016-05-28 10:16 ` Michal Nazarewicz
2016-05-28 10:16 ` Michal Nazarewicz
2016-05-28 10:15 ` [patch] " Michal Nazarewicz
2016-05-28 10:53 ` Dan Carpenter
2016-05-28 11:05 ` Dan Carpenter
2016-05-28 12:01 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528044618.GQ11011@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.