From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Wang Nan <wangnan0@huawei.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 4/7] perf config: Reimplement perf_config() using perf_config_set__iter()
Date: Mon, 30 May 2016 16:32:54 -0300 [thread overview]
Message-ID: <20160530193254.GC2563@kernel.org> (raw)
In-Reply-To: <1464626651-1523-5-git-send-email-treeze.taeung@gmail.com>
Em Tue, May 31, 2016 at 01:44:08AM +0900, Taeung Song escreveu:
> +static int perf_config_set__iter(struct perf_config_set *set, config_fn_t fn, void *data)
> +{
> + struct perf_config_section *section;
> + struct perf_config_item *item;
> + struct list_head *sections;
> + char key[BUFSIZ];
> +
> + if (set == NULL)
> + return -1;
<SNIP>
> + return 0;
> +}
> +int perf_config(config_fn_t fn, void *data)
> +{
> + if (perf_config_set__check() < 0)
> + return -1;
> + return perf_config_set__iter(config_set, fn, data);
> +}
"check" looks too vague, this is equivalent, no?
int perf_config(config_fn_t, void *data)
{
if (config_set == NULL)
config_set = perf_config_set__new();
return perf_config_set__iter(config_set, fn, data);
}
- Arnaldo
next prev parent reply other threads:[~2016-05-30 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 16:44 [RFC][PATCH v3 0/7] perf config: Reimplement perf_config() using perf_config_set__inter() Taeung Song
2016-05-30 16:44 ` [PATCH v3 1/7] perf config: Use new perf_config_set__init() to initialize config set Taeung Song
2016-05-30 16:44 ` [PATCH v3 2/7] perf config: Add global variable 'config_set' Taeung Song
2016-05-30 16:44 ` [PATCH v3 3/7] perf config: Modify perf_config_set__delete() using " Taeung Song
2016-05-30 19:29 ` Arnaldo Carvalho de Melo
2016-05-30 22:19 ` Taeung Song
2016-05-30 16:44 ` [PATCH v3 4/7] perf config: Reimplement perf_config() using perf_config_set__iter() Taeung Song
2016-05-30 19:32 ` Arnaldo Carvalho de Melo [this message]
2016-05-30 22:21 ` Taeung Song
2016-05-30 16:44 ` [PATCH v3 5/7] perf config: Reimplement show_config() using perf_config() Taeung Song
2016-05-30 16:44 ` [PATCH v3 6/7] perf config: Remove needless code about config set at cmd_config() Taeung Song
2016-05-30 19:35 ` Arnaldo Carvalho de Melo
2016-05-30 22:23 ` Taeung Song
2016-05-30 16:44 ` [PATCH v3 7/7] perf config: Reset the config set at only 'config' sub-command Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530193254.GC2563@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.