From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:43643 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161791AbcE3ULC (ORCPT ); Mon, 30 May 2016 16:11:02 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F7FB3B702 for ; Mon, 30 May 2016 20:11:01 +0000 (UTC) Received: from redhat.com (vpn-53-124.rdu2.redhat.com [10.10.53.124]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4UKAvlo001496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 30 May 2016 16:11:00 -0400 Date: Mon, 30 May 2016 22:10:56 +0200 From: Carlos Maiolino To: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] overlayfs: Do d_type check only if work dir creation was successful Message-ID: <20160530201056.GA11155@redhat.com> References: <20160520130426.GA31667@redhat.com> <20160523120150.GB21456@redhat.com> <20160523140412.GA4931@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160523140412.GA4931@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 23, 2016 at 10:04:12AM -0400, Vivek Goyal wrote: > On Mon, May 23, 2016 at 02:01:50PM +0200, Carlos Maiolino wrote: > > Hi Vivek. > > > > On Fri, May 20, 2016 at 09:04:26AM -0400, Vivek Goyal wrote: > > > d_type check requires successful creation of workdir as iterates > > > through work dir and expects work dir to be present in it. If that's > > > not the case, this check will always return d_type not supported even > > > if underlying filesystem might be supporting it. > > > > > > > ovl_check_d_type_supported, will call iterate_dir(), which is supposed to return > > -ENOENT if the work dir is not present AFAICT, isn't that enough to detect if > > work dir is present and handle it accordingly? > > Hi Carlos, > > So there is directory "work" under user specified workdir. Say user > specified "overlaywork" as workdir, then we are listing contents of " > overlaywork" and which should find "work" underneath it. Even if "work" > creation failed, "." and ".." are found and returned and their types > are returned as DT_DIR (despite the fact that filesystem does not support > d_type"). > > So in short, I am not getting -ENOENT if work dir creation failed. > > Thanks > Vivek > Hi Vivek, my apologies for my delay, I had some problems with my mail filter and I missed your reply before. Thanks for the explanation, it makes sense to me, you can add: Reviewed-by: Carlos Maiolino Cheers -- Carlos