From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nf-next PATCH v2] netfilter: nf_tables: add support for inverted login in nft_lookup
Date: Tue, 31 May 2016 14:08:19 +0200 [thread overview]
Message-ID: <20160531120819.GA6491@salvia> (raw)
In-Reply-To: <146469577386.17442.8631583064566384839.stgit@nfdev2.cica.es>
On Tue, May 31, 2016 at 01:57:16PM +0200, Arturo Borrero Gonzalez wrote:
> @@ -55,6 +58,7 @@ static int nft_lookup_init(const struct nft_ctx *ctx,
> {
> struct nft_lookup *priv = nft_expr_priv(expr);
> struct nft_set *set;
> + u32 flags;
> int err;
>
> if (tb[NFTA_LOOKUP_SET] == NULL ||
> @@ -91,6 +95,12 @@ static int nft_lookup_init(const struct nft_ctx *ctx,
> } else if (set->flags & NFT_SET_MAP)
> return -EINVAL;
>
> + if (tb[NFTA_LOOKUP_FLAGS]) {
> + flags = ntohl(nla_get_be32(tb[NFTA_LOOKUP_FLAGS]));
I missed this one before:
if (flags & ~NFT_LOOKUP_F_INV)
return -EINVAL;
> + if (flags & NFT_LOOKUP_F_INV)
> + priv->invert = true;
> + }
> +
> priv->binding.flags = set->flags & NFT_SET_MAP;
>
> err = nf_tables_bind_set(ctx, set, &priv->binding);
> @@ -112,6 +122,7 @@ static void nft_lookup_destroy(const struct nft_ctx *ctx,
prev parent reply other threads:[~2016-05-31 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:57 [nf-next PATCH v2] netfilter: nf_tables: add support for inverted login in nft_lookup Arturo Borrero Gonzalez
2016-05-31 12:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531120819.GA6491@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.