From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Date: Tue, 31 May 2016 15:36:22 +0300 Message-ID: <20160531123622.GT4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 548476E55D for ; Tue, 31 May 2016 12:36:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1464691994-5704-5-git-send-email-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMzEsIDIwMTYgYXQgMTI6NTM6MTJQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCAyICsrCj4gIGluY2x1ZGUvZHJt L2RybV9jcnRjLmggICAgIHwgMiArKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fY3J0Yy5jCj4gaW5kZXggZDJhNmQ5NS4uY2U1YTI4MCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f Y3J0Yy5jCj4gQEAgLTI5NzcsNiArMjk3Nyw4IEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29y X3VuaXZlcnNhbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQlEUk1fREVCVUdfS01TKCJm YWlsZWQgdG8gd3JhcCBjdXJzb3IgYnVmZmVyIGluIGRybSBmcmFtZWJ1ZmZlclxuIik7Cj4gIAkJ CQlyZXR1cm4gUFRSX0VSUihmYik7Cj4gIAkJCX0KPiArCQkJZmItPmhvdF94ID0gcmVxLT5ob3Rf eDsKPiArCQkJZmItPmhvdF95ID0gcmVxLT5ob3RfeTsKPiAgCQl9IGVsc2Ugewo+ICAJCQlmYiA9 IE5VTEw7Cj4gIAkJfQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oIGIvaW5j bHVkZS9kcm0vZHJtX2NydGMuaAo+IGluZGV4IGQxNTU5Y2QuLjE0NjBmNjYgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgK PiBAQCAtMjUzLDYgKzI1Myw4IEBAIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgewo+ICAJaW50IGJp dHNfcGVyX3BpeGVsOwo+ICAJaW50IGZsYWdzOwo+ICAJdWludDMyX3QgcGl4ZWxfZm9ybWF0OyAv KiBmb3VyY2MgZm9ybWF0ICovCj4gKwlpbnQgaG90X3g7Cj4gKwlpbnQgaG90X3k7Cj4gIAlzdHJ1 Y3QgbGlzdF9oZWFkIGZpbHBfaGVhZDsKPiAgfTsKCldoeSBzdG9yZSBpdCBpbiB0aGUgZmIgYW5k IG5vdCBlZy4gdGhlIHBsYW5lIHN0YXRlPwoKPiAgCj4gLS0gCj4gMS44LjMuMQo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbcEaMg2 (ORCPT ); Tue, 31 May 2016 08:36:28 -0400 Received: from mga11.intel.com ([192.55.52.93]:38050 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbcEaMg0 (ORCPT ); Tue, 31 May 2016 08:36:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="711552971" Date: Tue, 31 May 2016 15:36:22 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, open list Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Message-ID: <20160531123622.GT4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464691994-5704-5-git-send-email-kraxel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > include/drm/drm_crtc.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index d2a6d95..ce5a280 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2977,6 +2977,8 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, > DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n"); > return PTR_ERR(fb); > } > + fb->hot_x = req->hot_x; > + fb->hot_y = req->hot_y; > } else { > fb = NULL; > } > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index d1559cd..1460f66 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -253,6 +253,8 @@ struct drm_framebuffer { > int bits_per_pixel; > int flags; > uint32_t pixel_format; /* fourcc format */ > + int hot_x; > + int hot_y; > struct list_head filp_head; > }; Why store it in the fb and not eg. the plane state? > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC