From: "Daniel P. Berrange" <berrange@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu devel list <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] including the "git describe" output in the QEMU binaries?
Date: Tue, 31 May 2016 14:19:42 +0100 [thread overview]
Message-ID: <20160531131942.GS21628@redhat.com> (raw)
In-Reply-To: <20160531113248.GP21628@redhat.com>
On Tue, May 31, 2016 at 12:32:48PM +0100, Daniel P. Berrange wrote:
> On Tue, May 31, 2016 at 01:16:14PM +0200, Laszlo Ersek wrote:
> > Hi,
> >
> > has this been raised / considered before? To me at least it would be
> > extremely useful if QEMU binaries built from a git working directory
> > returned the output of "git describe" (+ possibly a hint about an
> > unclean working directory), when invoked with "-version".
> >
> > Not volunteering for the implementation, and also not suggesting /
> > requesting that others implement it (everyone is busy with real stuff,
> > I'm sure); just asking if it's been considered.
>
> Currently configure supports a --pkgversion flag which is used by people
> packaging QEMU in RPM/Debs to include their arbitrary custom version string.
> This information is then reported by -version and the appropriate QMP
> command.
>
> We could quite easily make configure default the pkgversion to the current
> GIT hash if --pkgversion is not explicitly given.
Oh and the nice thing about this is that it is plumbed into libvirt, so
whenever libvirt starts a guest, it will log the pkgversion associated
with QEMU to /var/log/libvirt/qemu/$GUEST.log
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-05-31 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:16 [Qemu-devel] including the "git describe" output in the QEMU binaries? Laszlo Ersek
2016-05-31 11:32 ` Daniel P. Berrange
2016-05-31 12:16 ` Laszlo Ersek
2016-05-31 13:19 ` Daniel P. Berrange [this message]
2016-05-31 13:26 ` Laszlo Ersek
2016-06-01 1:31 ` [Qemu-devel] [PATCH 0/2] Let PKGVERSION include the "git describe" output Fam Zheng
2016-06-01 1:31 ` [Qemu-devel] [PATCH 1/2] Makefile: Add a "FORCE" target Fam Zheng
2016-06-01 1:31 ` [Qemu-devel] [PATCH 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default Fam Zheng
2016-06-01 3:05 ` Eric Blake
2016-06-01 3:17 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531131942.GS21628@redhat.com \
--to=berrange@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.