Re: [Qemu-devel] [PATCH 4/4] trace: enable trace events in qemu-img

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, May 31, 2016 at 06:50:04AM -0600, Eric Blake wrote:
> On 05/31/2016 04:07 AM, Denis V. Lunev wrote:
> > The command will work this way:
> >     qemu-img create --trace qcow2* -f qcow2 1.img 64G
> > 
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> > Suggested by: Daniel P. Berrange <berrange@redhat.com>
> > CC: Eric Blake <eblake@redhat.com>
> > CC: Paolo Bonzini <pbonzini@redhat.com>
> > CC: Stefan Hajnoczi <stefanha@redhat.com>
> > CC: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qemu-img.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 96 insertions(+), 1 deletion(-)
> 
> Missing man page additions.
> 
> 
> > @@ -155,7 +157,12 @@ static void QEMU_NORETURN help(void)
> >             "Parameters to compare subcommand:\n"
> >             "  '-f' first image format\n"
> >             "  '-F' second image format\n"
> > -           "  '-s' run in Strict mode - fail on different image size or sector allocation\n";
> > +           "  '-s' run in Strict mode - fail on different image size or sector allocation\n"
> > +           "\n"
> > +           "General purpose options:\n"
> > +           "  -R, --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
> > +           "       specify tracing options\n"
> > +           "       see qemu(1) man page for full description\n";
> 
> Why -R? Because -T is already in use by rebase and compare?  I'd almost
> rather have _just_ --trace with no short option, than to pick yet
> another letter, but you might want to wait for other opinions first.

Agreed, I think it'd be fine to use --trace and skip the short option

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|