From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Date: Tue, 31 May 2016 16:54:27 +0300 Message-ID: <20160531135427.GU4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> <20160531123622.GT4329@intel.com> <1464700153.5978.107.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 73F1F6E60B for ; Tue, 31 May 2016 13:54:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1464700153.5978.107.camel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMzEsIDIwMTYgYXQgMDM6MDk6MTNQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBPbiBEaSwgMjAxNi0wNS0zMSBhdCAxNTozNiArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IAo+ID4gV2h5IHN0b3JlIGl0IGluIHRoZSBmYiBhbmQgbm90IGVnLiB0aGUgcGxh bmUgc3RhdGU/Cj4gCj4gV2VsbCwgZHJtX3BsYW5lX3N0YXRlIGlzIGFsbG9jYXRlZCBieSBkcm1f YXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUuCj4gCj4gV2hlbiBzdGlja2luZyB0aGUgaG90c3Bv dCBpbnRvIHRoZSB0aGUgcGxhbmUgc3RhdGUgd2UgaGF2ZSB0byBhZGQgaG90X3gKPiBhbmQgaG90 X3kgcGFyYW1ldGVycyB0byBkcm1fcGxhbmVfZnVuY3MtPnVwZGF0ZV9wbGFuZSgpIGFuZCBjYXVz ZSBxdWl0ZQo+IHNvbWUgY2h1cm4gYWxsIG92ZXIgdGhlIGRybSB0cmVlLgo+IAo+IE9yIGNyZWF0 ZSBhIHNlcGFyYXRlIGNvZGUgcGF0aCBmb3IgY3Vyc29yIHVwZGF0ZXMgd2hpY2ggdXNlcyBhIHNw ZWNpYWwKPiBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUgdmVyc2lvbiwgd2hpY2ggZG9l c24ndCBsb29rIHZlcnkKPiBhdHRyYWN0aXZlIHRvbyBkdWUgdG8gY29kZSBkdXBsaWNhdGlvbi4K PiAKPiBTdGlja2luZyBpdCBpbnRvIHRoZSBkcm1fZnJhbWVidWZmZXIgaW5zdGVhZCBsb29rcyBs aWtlIGEgcmVhc29uYWJsZQo+IGFsdGVybmF0aXZlLgo+IAo+IEknbSBvcGVuIHRvIGJldHRlciBz dWdnZXN0aW9ucy4KCkhtbS4gVG9vIG1hbnkgbGF5ZXJzLiBJIGd1ZXNzIHRoaXMgaXMgdGhlIGVh c2llc3Qgc29sdXRpb24gdGhlbi4gSSB3YXMKaG9waW5nIHRvIGF2b2lkIGZhdHRlbmluZyB0aGUg ZmIgZm9yIHNvbWV0aGluZyBzbyByYXJlbHkgdXNlZCwgYnV0IEkKZ3Vlc3MgdGhlcmUncyBubyBz YW5lIHdheSB0byBhY2hpZXZlIHRoYXQuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754394AbcEaNye (ORCPT ); Tue, 31 May 2016 09:54:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:16089 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbcEaNyc (ORCPT ); Tue, 31 May 2016 09:54:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="988091456" Date: Tue, 31 May 2016 16:54:27 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, open list Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Message-ID: <20160531135427.GU4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> <20160531123622.GT4329@intel.com> <1464700153.5978.107.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1464700153.5978.107.camel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 03:09:13PM +0200, Gerd Hoffmann wrote: > On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > > > Why store it in the fb and not eg. the plane state? > > Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. > > When sticking the hotspot into the the plane state we have to add hot_x > and hot_y parameters to drm_plane_funcs->update_plane() and cause quite > some churn all over the drm tree. > > Or create a separate code path for cursor updates which uses a special > drm_atomic_helper_update_plane version, which doesn't look very > attractive too due to code duplication. > > Sticking it into the drm_framebuffer instead looks like a reasonable > alternative. > > I'm open to better suggestions. Hmm. Too many layers. I guess this is the easiest solution then. I was hoping to avoid fattening the fb for something so rarely used, but I guess there's no sane way to achieve that. -- Ville Syrjälä Intel OTC