All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: david.s.gordon@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: drm/i915/guc: add enable_guc_loading parameter
Date: Tue, 31 May 2016 18:57:52 +0300	[thread overview]
Message-ID: <20160531155752.GA15577@mwanda> (raw)

Hello Dave Gordon,

This is a semi-automatic email about new static checker warnings.

The patch fce91f22ff31: "drm/i915/guc: add enable_guc_loading
parameter" from May 20, 2016, leads to the following Smatch complaint:

    drivers/gpu/drm/i915/intel_guc_loader.c:418 intel_guc_setup()
    error: we previously assumed 'fw_path' could be null (see line 417)

drivers/gpu/drm/i915/intel_guc_loader.c
   416			goto fail;
   417		} else if (fw_path == NULL || *fw_path == '\0') {
                           ^^^^^^^^^^^^^^^
New check.

   418			if (*fw_path == '\0')
                            ^^^^^^^^^^^^^^^
Oops.

   419				DRM_INFO("No GuC firmware known for this platform\n");
   420			err = -ENODEV;

regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

                 reply	other threads:[~2016-05-31 15:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531155752.GA15577@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.