From: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fix assorted memory leaks on error paths
Date: Tue, 31 May 2016 17:33:17 -0400 [thread overview]
Message-ID: <20160531213317.GC57351@redhat.com> (raw)
In-Reply-To: <20160526051010.GR25500-2ukJVAZIZ/Y@public.gmane.org>
On Thu, May 26, 2016 at 08:10:10AM +0300, Leon Romanovsky wrote:
> On Wed, May 18, 2016 at 01:07:47PM -0400, Jarod Wilson wrote:
> > Clang noticed that we might leak mcg_params.ib_devname in failure paths.
> > There are additional leaks after fixing this initial one that it still
> > reported, here's hoping I've got them all now...
...
> > return send_destroy_ctx(&ctx,&user_param,&mcg_params);
> > +
> > +failure2:
>
> Where is "failure1" ?
>
> > + free(my_dest);
> > + free(rem_dest);
> > + destroy_ctx(&ctx,&user_param);
> > +failure:
I considered 'failure' to be failure1, I guess. Really not picky on the
label names.
--
Jarod Wilson
jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-05-31 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 17:07 [PATCH] Fix assorted memory leaks on error paths Jarod Wilson
[not found] ` <1463591267-29975-1-git-send-email-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-26 5:10 ` Leon Romanovsky
[not found] ` <20160526051010.GR25500-2ukJVAZIZ/Y@public.gmane.org>
2016-05-31 21:33 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531213317.GC57351@redhat.com \
--to=jarod-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.