From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing
Date: Wed, 1 Jun 2016 10:26:12 +0800 [thread overview]
Message-ID: <20160601022612.GB8639@ad.usersys.redhat.com> (raw)
In-Reply-To: <81bebb8b-25f8-26de-a3b5-d1f800534b46@redhat.com>
On Tue, 05/31 14:48, Paolo Bonzini wrote:
>
>
> On 31/05/2016 14:40, Fam Zheng wrote:
> > > I'm still a bit undecided about the pollution introduced by
> > > tests/docker/Makefile.include, but I guess that's okay.
> >
> > I think it's also okay to switch to "make -C tests/docker" for docker targets
> > (so "make docker" becomes "make -C tests/docker help"), this way the top
> > Makefile is not touched.
>
> That would be a bit harder to discover. Go ahead with your current
> solution. Perhaps rename SRC_COPY to DOCKER_SRC_COPY?
OK, good idea.
Fam
next prev parent reply other threads:[~2016-06-01 2:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 13:54 [Qemu-devel] [PATCH v6 00/15] tests: Introducing docker tests Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 01/15] tests: Add utilities for docker testing Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 02/15] rules.mak: Add "COMMA" constant Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 03/15] rules.mak: Avoid double include Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing Fam Zheng
2016-05-31 8:51 ` Paolo Bonzini
2016-05-31 11:00 ` Fam Zheng
2016-05-31 12:02 ` Paolo Bonzini
2016-05-31 12:40 ` Fam Zheng
2016-05-31 12:48 ` Paolo Bonzini
2016-06-01 2:26 ` Fam Zheng [this message]
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 05/15] docker: Add images Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 06/15] docker: Add test runner Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 07/15] docker: Add common.rc Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 08/15] docker: Add quick test Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 09/15] docker: Add full test Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 10/15] docker: Add clang test Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 11/15] docker: Add mingw test Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 12/15] docker: Add travis tool Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 13/15] docs: Add text for tests/docker in build-system.txt Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 14/15] docker: Add EXTRA_CONFIGURE_OPTS Fam Zheng
2016-05-27 13:54 ` [Qemu-devel] [PATCH v6 15/15] MAINTAINERS: Add tests/docker Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601022612.GB8639@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.