From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3] virtio: split virtio rx/tx queue
Date: Wed, 1 Jun 2016 15:15:46 +0800
Message-ID: <20160601071546.GC10038@yliu-dev.sh.intel.com>
References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com>
 <1464599180-76004-1-git-send-email-huawei.xie@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Huawei Xie <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 4B7722C33
 for <dev@dpdk.org>; Wed,  1 Jun 2016 09:12:56 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1464599180-76004-1-git-send-email-huawei.xie@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote:
> We keep a common vq structure, containing only vq related fields,
> and then split others into RX, TX and control queue respectively.
> 
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> ---
> v2:
> - don't split virtio_dev_rx/tx_queue_setup
> v3:
> - fix some 80 char warnings
> - fix other newer version checkpatch warnings
> - remove '\n' in PMD_RX_LOG

Weird, I still saw them.

Besides that, I found a crash issue with this patch applied. You could
easily reproduce it by:

    testpmd> start tx_first
    testpmd> quit

    [82774.055297] testpmd[9661]: segfault at 94 ip 00000000004f7ef0 sp 00007ffcb1fa
    66c0 error 4 in testpmd[400000+25b000]
    ./t.pmd: line 11:  9661 Segmentation fault           (core dumped) $RTE_SDK/$RTE
    _TARGET/app/testpmd -c 0x1f -n 4 -- --nb-cores=4 -i --disable-hw-vlan --txqflags
     0xf00 --rxq=$nr_queues --txq=$nr_queues --rxd=256 --txd=256

	--yliu