From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v5 2/8] virtio: clean up
	virtio_dev_queue_setup
Date: Wed, 1 Jun 2016 15:38:14 +0800
Message-ID: <20160601073814.GD10038@yliu-dev.sh.intel.com>
References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com>
 <1464605739-140761-1-git-send-email-jianfeng.tan@intel.com>
 <1464605739-140761-3-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Huawei Xie <huawei.xie@intel.com>,
 rich.lane@bigswitch.com, mst@redhat.com,
 nakajima.yoshihiro@lab.ntt.co.jp, p.fedin@samsung.com,
 ann.zhuangyanying@huawei.com, mukawa@igel.co.jp, nhorman@tuxdriver.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6F0823237
 for <dev@dpdk.org>; Wed,  1 Jun 2016 09:35:25 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1464605739-140761-3-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 30, 2016 at 10:55:33AM +0000, Jianfeng Tan wrote:
> Abstract vring hdr desc init as an inline method.

What's this patch for then? In your last version, it will be invoked
twice, but it turned out to be wrong. So, why keeping this change?
I didn't see it improves anything.

	--yliu