From: Christoph Hellwig <hch@infradead.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Michal Hocko <mhocko@suse.com>, Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
iommu@lists.linux-foundation.org,
linux-samsung-soc@vger.kernel.org, sstabellini@kernel.org,
Andy Lutomirski <luto@kernel.org>,
xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 1 Jun 2016 00:51:42 -0700 [thread overview]
Message-ID: <20160601075142.GA1700@infradead.org> (raw)
In-Reply-To: <574E746A.2030806@samsung.com>
On Wed, Jun 01, 2016 at 07:36:42AM +0200, Krzysztof Kozlowski wrote:
> > No really for this patch, but I would much prefer to document them next
> > to the code in the long run. Also I really think these BIT() macros
> > are a distraction compared to the (1 << N) notation.
>
> Not much difference to me but maybe plain number:
> ... 0x01u
> ... 0x02u
> ?
I prefer the little bit shifts, but even the explicit values are much
better than the obsfucating macros :) Anyway, your patch and in the end
all three methods will get the work done.
> > I'd just kill this helper, much easier to simply open code it in the
> > caller.
>
> Keeping it for now helps reducing the number of changes in the patch.
> The patch will be quite big as it has to replace all the uses atomically.
>
> I can get rid of the helper in consecutive patch.
Sounds fine.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2] dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 1 Jun 2016 00:51:42 -0700 [thread overview]
Message-ID: <20160601075142.GA1700@infradead.org> (raw)
In-Reply-To: <574E746A.2030806@samsung.com>
On Wed, Jun 01, 2016 at 07:36:42AM +0200, Krzysztof Kozlowski wrote:
> > No really for this patch, but I would much prefer to document them next
> > to the code in the long run. Also I really think these BIT() macros
> > are a distraction compared to the (1 << N) notation.
>
> Not much difference to me but maybe plain number:
> ... 0x01u
> ... 0x02u
> ?
I prefer the little bit shifts, but even the explicit values are much
better than the obsfucating macros :) Anyway, your patch and in the end
all three methods will get the work done.
> > I'd just kill this helper, much easier to simply open code it in the
> > caller.
>
> Keeping it for now helps reducing the number of changes in the patch.
> The patch will be quite big as it has to replace all the uses atomically.
>
> I can get rid of the helper in consecutive patch.
Sounds fine.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@techsingularity.net>,
Arnd Bergmann <arnd@arndb.de>, Andy Lutomirski <luto@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
iommu@lists.linux-foundation.org, sstabellini@kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 1 Jun 2016 00:51:42 -0700 [thread overview]
Message-ID: <20160601075142.GA1700@infradead.org> (raw)
In-Reply-To: <574E746A.2030806@samsung.com>
On Wed, Jun 01, 2016 at 07:36:42AM +0200, Krzysztof Kozlowski wrote:
> > No really for this patch, but I would much prefer to document them next
> > to the code in the long run. Also I really think these BIT() macros
> > are a distraction compared to the (1 << N) notation.
>
> Not much difference to me but maybe plain number:
> ... 0x01u
> ... 0x02u
> ?
I prefer the little bit shifts, but even the explicit values are much
better than the obsfucating macros :) Anyway, your patch and in the end
all three methods will get the work done.
> > I'd just kill this helper, much easier to simply open code it in the
> > caller.
>
> Keeping it for now helps reducing the number of changes in the patch.
> The patch will be quite big as it has to replace all the uses atomically.
>
> I can get rid of the helper in consecutive patch.
Sounds fine.
next prev parent reply other threads:[~2016-06-01 7:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 11:54 [RFC v2] Change dma_attrs from bitfield to unsigned long Krzysztof Kozlowski
2016-05-30 11:54 ` Krzysztof Kozlowski
[not found] ` <1464609246-6948-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-30 11:54 ` [RFC v2] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-05-30 11:54 ` Krzysztof Kozlowski
2016-05-30 11:54 ` Krzysztof Kozlowski
2016-05-31 17:04 ` Christoph Hellwig
2016-05-31 17:04 ` Christoph Hellwig
2016-05-31 17:04 ` Christoph Hellwig
2016-05-31 17:04 ` Christoph Hellwig
2016-06-01 5:36 ` Krzysztof Kozlowski
2016-06-01 5:36 ` Krzysztof Kozlowski
2016-06-01 7:51 ` Christoph Hellwig
2016-06-01 7:51 ` Christoph Hellwig [this message]
2016-06-01 7:51 ` Christoph Hellwig
2016-06-01 7:51 ` Christoph Hellwig
2016-06-01 5:36 ` Krzysztof Kozlowski
2016-05-31 18:15 ` Konrad Rzeszutek Wilk
2016-05-31 18:15 ` Konrad Rzeszutek Wilk
2016-05-31 18:15 ` Konrad Rzeszutek Wilk
2016-05-31 18:15 ` Konrad Rzeszutek Wilk
2016-06-01 6:08 ` Krzysztof Kozlowski
2016-06-01 6:08 ` Krzysztof Kozlowski
2016-06-01 6:08 ` Krzysztof Kozlowski
2016-05-30 11:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601075142.GA1700@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=sstabellini@kernel.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.