From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] fq_codel: add per queue memory limit
Date: Wed, 1 Jun 2016 08:53:40 -0700 [thread overview]
Message-ID: <20160601085340.4b3c84dc@xeon-e3> (raw)
In-Reply-To: <1464791011.5939.150.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, 01 Jun 2016 07:23:31 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> + } else if (strcmp(*argv, "memory_limit") == 0) {
> + NEXT_ARG();
> + if (get_size(&memory, *argv)) {
> + fprintf(stderr, "Illegal \"memory_limit\"\n");
> + return -1;
> + }
Do you really want to allow memory limit of 0?
> + if (tb[TCA_FQ_CODEL_MEMORY_LIMIT] &&
> + RTA_PAYLOAD(tb[TCA_FQ_CODEL_MEMORY_LIMIT]) >= sizeof(__u32)) {
> + memory_limit = rta_getattr_u32(tb[TCA_FQ_CODEL_MEMORY_LIMIT]);
> +
> + fprintf(f, "memory_limit %s ", sprint_size(memory_limit, b1));
> + }
Why the size check? other parameters don't do it?
next prev parent reply other threads:[~2016-06-01 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 14:23 [PATCH iproute2] fq_codel: add per queue memory limit Eric Dumazet
2016-06-01 15:53 ` Stephen Hemminger [this message]
2016-06-01 16:01 ` Eric Dumazet
2016-06-08 15:33 ` Stephen Hemminger
2016-06-08 22:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601085340.4b3c84dc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.