From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 Date: Wed, 1 Jun 2016 11:01:08 -0300 Message-ID: <20160601140108.GC11486@joana> References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f169.google.com (mail-yw0-f169.google.com [209.85.161.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDB706E9BE for ; Wed, 1 Jun 2016 14:01:14 +0000 (UTC) Received: by mail-yw0-f169.google.com with SMTP id o16so18941980ywd.2 for ; Wed, 01 Jun 2016 07:01:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXN0aWFuLAoKMjAxNi0wNi0wMSBDaHJpc3RpYW4gS8O2bmlnIDxkZWF0aHNpbXBsZUB2 b2RhZm9uZS5kZT46Cgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNv bGxhYm9yYS5jby51az4KPiAKPiBzdHJ1Y3QgZmVuY2VfY29sbGVjdGlvbiBpbmhlcml0cyBmcm9t IHN0cnVjdCBmZW5jZSBhbmQgY2FycmllcyBhCj4gY29sbGVjdGlvbiBvZiBmZW5jZXMgdGhhdCBu ZWVkcyB0byBiZSB3YWl0ZWQgdG9nZXRoZXIuCj4gCj4gSXQgaXMgdXNlZnVsIHRvIHRyYW5zbGF0 ZSBhIHN5bmNfZmlsZSB0byBhIGZlbmNlIHRvIHJlbW92ZSB0aGUgY29tcGxleGl0eQo+IG9mIGRl YWxpbmcgd2l0aCBzeW5jX2ZpbGVzIG9uIERSTSBkcml2ZXJzLiBTbyBldmVuIGlmIHRoZXJlIGFy ZSBtYW55Cj4gZmVuY2VzIGluIHRoZSBzeW5jX2ZpbGUgdGhhdCBuZWVkcyB0byB3YWl0ZWQgZm9y IGEgY29tbWl0IHRvIGhhcHBlbiwKPiB0aGV5IGFsbCBnZXQgYWRkZWQgdG8gdGhlIGZlbmNlX2Nv bGxlY3Rpb24gYW5kIHBhc3NlZCBmb3IgRFJNIHVzZSBhcwo+IGEgc3RhbmRhcmQgc3RydWN0IGZl bmNlLgo+IAo+IFRoYXQgbWVhbnMgdGhhdCBubyBjaGFuZ2VzIG5lZWRlZCB0byBhbnkgZHJpdmVy IGJlc2lkZXMgc3VwcG9ydGluZyBmZW5jZXMuCj4gCj4gZmVuY2VfY29sbGVjdGlvbidzIGZlbmNl IGRvZXNuJ3QgYmVsb25nIHRvIGFueSB0aW1lbGluZSBjb250ZXh0LCBzbwo+IGZlbmNlX2lzX2xh dGVyKCkgYW5kIGZlbmNlX2xhdGVyKCkgYXJlIG5vdCBtZWFudCB0byBiZSBjYWxsZWQgd2l0aAo+ IGZlbmNlX2NvbGxlY3Rpb25zIGZlbmNlcy4KClRoZSBjb21taXQgbWVzc2FnZSBuZWVkcyB0byBi ZSBmaXhlZCB0byBzYXkgbWVudGlvbiBmZW5jZV9hcnJheSBpbnN0ZWFkCm9mIGZlbmNlX2NvbGxl Y3Rpb24gYW5kIHdlIGRvIGNyZWF0ZSBmZW5jZSBjb250ZXh0cyBmb3IgZmVuY2VfYXJyYXlzCm5v dy4KCglHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758321AbcFAOBQ (ORCPT ); Wed, 1 Jun 2016 10:01:16 -0400 Received: from mail-yw0-f181.google.com ([209.85.161.181]:35566 "EHLO mail-yw0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcFAOBO convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 10:01:14 -0400 Date: Wed, 1 Jun 2016 11:01:08 -0300 From: Gustavo Padovan To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 Message-ID: <20160601140108.GC11486@joana> Mail-Followup-To: Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, 2016-06-01 Christian König : > From: Gustavo Padovan > > struct fence_collection inherits from struct fence and carries a > collection of fences that needs to be waited together. > > It is useful to translate a sync_file to a fence to remove the complexity > of dealing with sync_files on DRM drivers. So even if there are many > fences in the sync_file that needs to waited for a commit to happen, > they all get added to the fence_collection and passed for DRM use as > a standard struct fence. > > That means that no changes needed to any driver besides supporting fences. > > fence_collection's fence doesn't belong to any timeline context, so > fence_is_later() and fence_later() are not meant to be called with > fence_collections fences. The commit message needs to be fixed to say mention fence_array instead of fence_collection and we do create fence contexts for fence_arrays now. Gustavo