From: Phil Sutter <phil@nwl.cc>
To: Greg Rose <gvrose8192@gmail.com>
Cc: Stephen Hemminger <shemming@brocade.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing
Date: Thu, 2 Jun 2016 00:07:50 +0200 [thread overview]
Message-ID: <20160601220750.GC2729@orbyte.nwl.cc> (raw)
In-Reply-To: <CALgkqUq5nedx+wjEur9WVjvYr0pzvL7CMQmHiVtuuB_1PtOZ2Q@mail.gmail.com>
On Wed, Jun 01, 2016 at 03:00:08PM -0700, Greg Rose wrote:
> On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter <phil@nwl.cc> wrote:
> > Not sure whether I misinterpret commit 7b8179c780a1a, but it looks
> > overly complicated. Instead rely upon parse_rtattr_nested() to assign
> > the relevant pointer if requested rtattr fields are present.
>
> I'm not sure if newer iproute2 utilities are supposed to work on older
> kernels but if it is you may want to check this against a 2.6.32
> kernel.
Yes, it is supposed to. Actually I tried, but the old RHEL6 kernel I
used didn't export the VF list at all and then I lost motivation.
I didn't check all earlier versions of 7b8179c780a1a, was there a stage
when it looked like what I'm changing it to?
Cheers, Phil
next prev parent reply other threads:[~2016-06-01 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 20:03 [iproute PATCH 0/2] Minor vf_info review Phil Sutter
2016-06-01 20:03 ` [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing Phil Sutter
2016-06-01 22:00 ` Greg Rose
2016-06-01 22:07 ` Phil Sutter [this message]
2016-06-01 22:36 ` Greg Rose
2016-07-01 17:50 ` Phil Sutter
2016-07-20 20:10 ` Phil Sutter
2016-08-17 21:27 ` Phil Sutter
2016-06-01 20:03 ` [iproute PATCH 2/2] ipaddress: Print IFLA_VF_QUERY_RSS_EN setting Phil Sutter
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 21:29 [iproute PATCH 0/2] Resend: Simplify and enhance vf_info parsing Phil Sutter
2016-11-08 21:29 ` [iproute PATCH 1/2] ipaddress: Simplify " Phil Sutter
2016-11-08 23:05 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601220750.GC2729@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=gvrose8192@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.