From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match Date: Thu, 2 Jun 2016 14:30:40 +0300 Message-ID: <20160602113040.GK4329@intel.com> References: <20160601094353.GC4329@intel.com> <1464774651-20376-1-git-send-email-chris@chris-wilson.co.uk> <574FFE92.6060806@radekdostal.com> <20160602105217.GL10319@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 1383C6E9F2 for ; Thu, 2 Jun 2016 11:30:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160602105217.GL10319@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Radek =?iso-8859-1?Q?Dost=E1l?= , dri-devel@lists.freedesktop.org, Jesse Barnes , Daniel Vetter , Julia Lemire , Dave Airlie , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMDIsIDIwMTYgYXQgMTE6NTI6MTdBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgSnVuIDAyLCAyMDE2IGF0IDExOjM4OjI2QU0gKzAyMDAsIFJhZGVrIERv c3TDoWwgd3JvdGU6Cj4gPiBPbiAwNi8wMS8yMDE2IDExOjUwIEFNLCBDaHJpcyBXaWxzb24gd3Jv dGU6Cj4gPiA+Rml4ZXMgcmVncmVzc2lvbiBmcm9tCj4gPiA+Cj4gPiA+Y29tbWl0IGVhZjk5Yzc0 OWQ0M2FlNzRhYzdmZmVjZTU1MTJmM2M3M2YwMWRmZDIKPiA+ID5BdXRob3I6IENocmlzIFdpbHNv bjxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+RGF0ZTogICBXZWQgQXVnIDYgMTA6MDg6 MzIgMjAxNCArMDIwMAo+ID4gPgo+ID4gPiAgICAgZHJtOiBQZXJmb3JtIGNtZGxpbmUgbW9kZSBw YXJzaW5nIGR1cmluZyBjb25uZWN0b3IgaW5pdGlhbGlzYXRpb24KPiA+ID4KPiA+ID50aGF0IGJy ZWFrcyBIRE1JIG91dHB1dCBvbiBCZWFnbGVCb25lIEJsYWNrIHdpdGggTEcgVFYgKG1vZGVsIDE5 TFM0Ui1aQSkuCj4gPiAKPiA+IHBsZWFzZSByZW1vdmUgdGhpcyBmcm9tIHRoZSBjb21taXQgbWVz c2FnZS4gVGhlIG9yaWdpbmFsIGJ1ZyBpcyBubwo+ID4gbG9uZ2VyIHJlcHJvZHVjaWJsZSB3aXRo IDQuNy1yYzEKPiAKPiBJZiB0aGVyZSdzIG5vIG1vdGl2YXRpb24gZm9yIHRoZSBwYXRjaCBhbnlt b3JlLCBpdCBjYW4ganVzdCB3aXRoZXIgYXdheQo+IGluIG9uZSBvZiBteSBvbGQgdHJlZXMuCj4g Cj4gRG9lcyBhbnlvbmUgY2FyZSBhYm91dCBwcnVuaW5nIHRoZSBhdXRvZ2VuZXJhdGVkIHZpZGVv PSBtb2RlIGlmIGEgcHJvYmVkCj4gb25lIG1hdGNoZXM/IFByZXN1bWFibHksIGl0IGlzIHN0aWxs IHZpc2libGUgdG8gdXNlcnNwYWNlIGFuZCBzd2l0Y2hpbmcKPiB0byBpdCB3aWxsIGNhdXNlIHRo ZSBzYW1lIGlzc3VlIGFzIGJlZm9yZT8gT3Igd2FzIGl0IGFsd2F5cyBhIGRyaXZlcgo+IGJ1ZyAo ZmFpbGluZyB0byBzZXQgdGhlIG1vZGUpPwoKSU1PIHRoZSBwYXRjaCBtYWtlcyB0b3RhbCBzZW5z ZSBldmVuIGlmIGl0J3Mgbm90IG5lZWRlZCBmb3IgdGhpcwpwYXJ0aWN1bGFyIGJ1Zy4gRmVlbCBm cmVlIHRvIGFkZAoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:10403 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcFBLbA (ORCPT ); Thu, 2 Jun 2016 07:31:00 -0400 Date: Thu, 2 Jun 2016 14:30:40 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson , Radek =?iso-8859-1?Q?Dost=E1l?= , dri-devel@lists.freedesktop.org, Jesse Barnes , Daniel Vetter , Julia Lemire , Dave Airlie , stable@vger.kernel.org Subject: Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match Message-ID: <20160602113040.GK4329@intel.com> References: <20160601094353.GC4329@intel.com> <1464774651-20376-1-git-send-email-chris@chris-wilson.co.uk> <574FFE92.6060806@radekdostal.com> <20160602105217.GL10319@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160602105217.GL10319@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote: > On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dost�l wrote: > > On 06/01/2016 11:50 AM, Chris Wilson wrote: > > >Fixes regression from > > > > > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2 > > >Author: Chris Wilson > > >Date: Wed Aug 6 10:08:32 2014 +0200 > > > > > > drm: Perform cmdline mode parsing during connector initialisation > > > > > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA). > > > > please remove this from the commit message. The original bug is no > > longer reproducible with 4.7-rc1 > > If there's no motivation for the patch anymore, it can just wither away > in one of my old trees. > > Does anyone care about pruning the autogenerated video= mode if a probed > one matches? Presumably, it is still visible to userspace and switching > to it will cause the same issue as before? Or was it always a driver > bug (failing to set the mode)? IMO the patch makes total sense even if it's not needed for this particular bug. Feel free to add Reviewed-by: Ville Syrj�l� -- Ville Syrj�l� Intel OTC