Re: [PATCH v1 for 4.7] Tmem cleanups.

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Thu, Jun 02, 2016 at 04:42:12PM +0100, Wei Liu wrote:
> On Thu, Jun 02, 2016 at 11:04:16AM -0400, Konrad Rzeszutek Wilk wrote:
> > Hey!
> > 
> > Since RFC [http://www.gossamer-threads.com/lists/xen/devel/431812]
> >  - Added Reviewed-by from Doug
> >  - Dropped the RFC
> > 
> > 
> > These four little cleanups move the bulk of tmem control ops
> > from tmem.c to tmem_control.c.
> > 
> > Last release I moved the control tmem ops from being part of tmem
> > hypercall to be part of the syscall subops - and this is the next
> > step in this cleanup. (See
> > http://lists.xen.org/archives/html/xen-devel/2015-10/msg03313.html)
> > which will allow me to follow up on the other steps:
> > b) Fix the toolstack (cleanup)
> > c) tmem tze, dedup, and zlib code drop
> > 
> > Anyhow sorry for this being so tardy - xSplice had more attention :-)
> > 
> 
> What do you mean here? There is no such thing called xSplice! :-P

Hehehe.
> 
> > Regression tests show no problems.
> > 
> > The patches themselves have no functionality changes thought I was itching
> > to remove most of the counters. I will do that going forward, but need
> > to figure out which ones make sense or if some of them can be coalesced. 
> > 
> > 
> >  xen/common/Makefile            |   2 +-
> >  xen/common/tmem.c              | 618 +++++------------------------------------
> >  xen/common/tmem_control.c      | 443 +++++++++++++++++++++++++++++
> >  xen/include/xen/tmem_control.h |  33 +++
> >  xen/include/xen/tmem_xen.h     | 128 +++++++++
> >  5 files changed, 672 insertions(+), 552 deletions(-)
> > 
> 
> Since this is only tmem code, the only risk is it doesn't build in
> osstest, but I think the probability is quite low.
> 
> If you confirm that it builds on Debian Jessie, that would be good
> enough for me:

Sure thing. Will make sure and if there are no issues will
push it in staging.

Thanks!
> 
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> > Konrad Rzeszutek Wilk (4):
> >       tmem: Move global stats in a tmem_statistics structure
> >       tmem: Wrap atomic_t in struct tmem_statistics as well.
> >       tmem: Move global_ individual variables in a global structure.
> >       tmem: Move bulk of tmem control functions in its own file.
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel