From: Javi Merino <javi.merino@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()
Date: Thu, 2 Jun 2016 19:02:50 +0100 [thread overview]
Message-ID: <20160602180250.GC2966@e104805> (raw)
In-Reply-To: <CAKohponBAEZMhiVPNKqbY3nHAT9uB=7rK=SvVaf4jfgMPPft9w@mail.gmail.com>
On Thu, Jun 02, 2016 at 09:06:26PM +0530, Viresh Kumar wrote:
> On 2 June 2016 at 20:29, Javi Merino <javi.merino@arm.com> wrote:
> > In 5a31d594a973 ("cpufreq: Allow freq_table to be obtained for offline
> > CPUs") you did the opposite: don't use cpufreq_cpu_get_raw() because
> > it won't give you the policy of a cpu that is offline. Now you are
> > arguing that we should go back to cpufreq_cpu_get() which implicitly
> > calls cpufreq_cpu_get_raw(). Won't we hit the same issue that
> > 5a31d594a973 was trying to prevent: that we can't get a freq_table for
> > a cpu that is offline?
>
> Yes, that should be fixed. Thanks for letting me know about it :)
Ok, that was my only nit. Other than that, it looks good to me. For cpu_cooling.c
Acked-by: Javi Merino <javi.merino@arm.com>
next prev parent reply other threads:[~2016-06-02 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:04 [PATCH V2 0/6] cpufreq: cleanups and reorganization Viresh Kumar
2016-06-02 14:04 ` [PATCH V2 1/6] cpufreq: s3c24xx: Remove useless checks Viresh Kumar
2016-06-02 14:04 ` [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table() Viresh Kumar
2016-06-02 14:59 ` Javi Merino
2016-06-02 15:36 ` Viresh Kumar
2016-06-02 18:02 ` Javi Merino [this message]
2016-06-03 5:11 ` Viresh Kumar
2016-06-02 14:04 ` [PATCH V2 3/6] cpufreq: ondemand: Don't keep a copy of freq_table pointer Viresh Kumar
2016-06-02 14:04 ` [PATCH V2 4/6] cpufreq: Drop freq-table param to cpufreq_frequency_table_target() Viresh Kumar
2016-06-02 14:04 ` [PATCH V2 5/6] cpufreq: Drop 'freq_table' argument of __target_index() Viresh Kumar
2016-06-02 14:05 ` [PATCH V2 6/6] cpufreq: Return index from cpufreq_frequency_table_target() Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602180250.GC2966@e104805 \
--to=javi.merino@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=edubezval@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.