From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
namhyung@kernel.org, adrian.hunter@intel.com,
sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
penberg@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/14] Add support for remote unwind
Date: Thu, 2 Jun 2016 22:35:04 +0200 [thread overview]
Message-ID: <20160602203504.GE26647@krava> (raw)
In-Reply-To: <1464861326-22677-1-git-send-email-hekuang@huawei.com>
On Thu, Jun 02, 2016 at 09:55:12AM +0000, He Kuang wrote:
SNIP
> and now we can use LIBUNWIND_DIR to specific custom dirctories
> containing libunwind libs.
>
> v8:
>
> - Put unwind__register_ops call into unwind__prepare_access from
> patch 4 to patch 3.
> - Fail thread__insert_map on error.
> - Remove unused macro HAVE_LIBUNWIND_LOCAL_SUPPORT.
> - Return once find that thread->addr_space is valid and check this
> value first.
> - Add comments in file 'util/libunwind/arm64.c',
> 'util/libunwind/x86_32.c', and explain the reason for debug-frame
> flag in non-arm arch.
apart from few nitpicks, this looks ok to me
I tried with 32bit unwind under 64bits and it works nicely,
plus 64bit unwind seems not to be broken as well ;-)
considerring those nitpicks solved:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
prev parent reply other threads:[~2016-06-02 20:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:55 [PATCH v8 00/14] Add support for remote unwind He Kuang
2016-06-02 9:55 ` [PATCH v8 01/14] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang
2016-06-02 9:55 ` [PATCH v8 02/14] perf tools: Decouple thread->address_space on libunwind He Kuang
2016-06-02 9:55 ` [PATCH v8 03/14] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang
2016-06-02 20:34 ` Jiri Olsa
2016-06-02 9:55 ` [PATCH v8 04/14] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map He Kuang
2016-06-02 20:33 ` Jiri Olsa
2016-06-02 9:55 ` [PATCH v8 05/14] perf tools: Don't mix LIBUNWIND_LIBS into LIBUNWIND_LDFLAGS He Kuang
2016-06-02 9:55 ` [PATCH v8 06/14] perf tools: Separate local/remote libunwind config He Kuang
2016-06-02 9:55 ` [PATCH v8 07/14] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang
2016-06-02 9:55 ` [PATCH v8 08/14] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang
2016-06-02 20:34 ` Jiri Olsa
2016-06-02 9:55 ` [PATCH v8 09/14] perf tools: Export normalize_arch() function He Kuang
2016-06-02 9:55 ` [PATCH v8 10/14] perf tools: Check the target platform before assigning unwind methods He Kuang
2016-06-02 9:55 ` [PATCH v8 11/14] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang
2016-06-02 9:55 ` [PATCH v8 12/14] perf tools: Introduce flag to separate local/remote unwind compilation He Kuang
2016-06-02 9:55 ` [PATCH v8 13/14] perf callchain: Support x86 target platform He Kuang
2016-06-02 20:34 ` Jiri Olsa
2016-06-02 9:55 ` [PATCH v8 14/14] perf callchain: Support aarch64 cross-platform He Kuang
2016-06-02 20:35 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602203504.GE26647@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.