From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, lgirdwood@gmail.com, ramesh.babu@intel.com,
senthilnathanx.veppur@intel.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt298: remove idle_bias_off = true
Date: Fri, 3 Jun 2016 00:40:19 +0100 [thread overview]
Message-ID: <20160602234019.GV2282@sirena.org.uk> (raw)
In-Reply-To: <1464850312-18069-1-git-send-email-bardliao@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]
On Thu, Jun 02, 2016 at 02:51:52PM +0800, Bard Liao wrote:
> Codec will not go into suspend if there is any widget forced on with
> idle_bias_off true. We want codec go into suspend when the system is
> suspend. Also, we don't do anything in bias level OFF case. So it is
> actually no different in bias level STANDBY or OFF case.
Hrm. This feels like something that the framework might be doing wrong
here. We should either suspend the CODEC all the time even if there are
widgets enabled or we should never suspend the CODEC even if there are
widgets enabled but having it depend on idle_bias_off seems like the
wrong thing here. My expectation would be that we would not suspend
with widgets on since the widgets being on implies the CODEC being on
and we'd expect suspend to do things like cutting the device level
power.
Could you talk through the use case in more detail - what's the widget
and why is it still OK for suspend to run even with widgets on?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-06-02 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 6:51 [PATCH] ASoC: rt298: remove idle_bias_off = true Bard Liao
2016-06-02 7:04 ` Vinod Koul
2016-06-02 23:40 ` Mark Brown [this message]
2016-06-03 3:09 ` Bard Liao
2016-06-06 18:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602234019.GV2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=ramesh.babu@intel.com \
--cc=senthilnathanx.veppur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.