From: Eryu Guan <eguan@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: xfs discontiguous multi-block buffer logging test
Date: Fri, 3 Jun 2016 11:31:58 +0800 [thread overview]
Message-ID: <20160603033158.GD5140@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1464873001-17508-1-git-send-email-bfoster@redhat.com>
On Thu, Jun 02, 2016 at 09:10:01AM -0400, Brian Foster wrote:
> XFS had a bug in the multi-block buffer logging code that caused a NULL
> lv panic at log push time due to invalid regions being set in the buffer
> log format bitmap. This was demonstrated by modifying a multi-block
> directory buffer in a manner that only logs regions beyond the first
> FSB-sized mapping of the buffer.
>
> To recreate these conditions, this test fragments free space and
> populates several directories with enough entries to require
> discontiguous multi-block buffers. To recreate the problem, we remove
> entries from the tail end of the directory and fsync to flush the log.
>
> Note that this test causes a panic on kernels affected by the bug. As
> such, it is included in the 'dangerous' group. The bug is resolved by
> kernel commit a3916e528b91 ("xfs: fix broken multi-fsb buffer logging").
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks good to me. Also tested on patched kernel with different block
size XFS, test passed within 20s for me.
Reviewed-by: Eryu Guan <eguan@redhat.com>
next prev parent reply other threads:[~2016-06-03 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 13:10 [PATCH v2] xfstests: xfs discontiguous multi-block buffer logging test Brian Foster
2016-06-03 3:31 ` Eryu Guan [this message]
2016-06-16 1:13 ` Dave Chinner
2016-06-16 11:45 ` Brian Foster
2016-06-16 15:10 ` Eric Sandeen
2016-06-20 22:48 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603033158.GD5140@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.