From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dent.vctlabs.com (net-cf9a4187.iis.impulse.net [207.154.65.135]) by mail.openembedded.org (Postfix) with ESMTP id 7930C7745B for ; Fri, 3 Jun 2016 05:38:52 +0000 (UTC) Received: by dent.vctlabs.com (Postfix, from userid 1000) id CEDBD28049C; Thu, 2 Jun 2016 22:38:52 -0700 (PDT) Date: Thu, 2 Jun 2016 22:38:52 -0700 From: "S. Lockwood-Childs" To: openembedded-devel@lists.openembedded.org Message-ID: <20160603053852.GD7939@vctlabs.com> Mail-Followup-To: "S. Lockwood-Childs" , openembedded-devel@lists.openembedded.org References: <20160602182426.GW7939@vctlabs.com> <20160602182641.GX7939@vctlabs.com> <57510F9A.8080400@mlbassoc.com> MIME-Version: 1.0 In-Reply-To: <57510F9A.8080400@mlbassoc.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 05:38:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 03, 2016 at 07:03:22AM +0200, Gary Thomas wrote: > On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote: > >Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py > >from bombing on import errors when running on python2 rather than python3.4 > > > > ImportError: No module named backports_abc > > > >Signed-off-by: S. Lockwood-Childs > > In my mind, this patch (and its sibling) don't really have anything to to > with Tornado, they are just new packages being added to make that package happy. > I'd prefer to see a commit message that reflects what this package is as well > as why it is being added. > >+SUMMARY = "collections.abc from Python 3.4" > >+DESCRIPTION = "A backport of recent additions to the 'collections.abc' module" What would you like to see, a repeat of the SUMMARY or DESCRIPTION lines added to the corresponding commit messages (if so, which)? Other than that, I don't know what else to say about them; if their absence wasn't breaking Tornado, I would not have picked either of these particular modules to submit. Neither one has much use yet outside of Tornado (found no other users of abc, while singledispatch is also used by rpy (python interface to R).