From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] adding tpm2.0 support to nuvoton drivers and adding npct6xx Date: Fri, 3 Jun 2016 11:30:01 +0300 Message-ID: <20160603083001.GA30613@intel.com> References: <20160602140634.6ab408bc@andrew-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20160602140634.6ab408bc@andrew-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: andrew Cc: Dan.Morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, stimpy1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Jun 02, 2016 at 02:06:34PM +0300, andrew wrote: > From 401214bfbece31e3ef783f13b762da6f83d10f84 Mon Sep 17 00:00:00 2001 > From: andrew azmansky > Date: Thu, 2 Jun 2016 09:13:28 +0300 > Subject: [PATCH] adding tpm2.0 support to nuvoton drivers and adding npct= 6xx > to device tree > = > Signed-off-by: Andrew Zamansky > = > --- > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + > drivers/char/tpm/tpm_i2c_nuvoton.c | 5 +++-- > drivers/char/tpm/tpm_tis.c | 2 +- > 3 files changed, 5 insertions(+), 3 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/= Documentation/devicetree/bindings/i2c/trivial-devices.txt > index 5398744..0a07cbc 100644 > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > @@ -62,6 +62,7 @@ national,lm80 Serial Interface ACPI-Compatible Micropr= ocessor System Hardware M > national,lm85 Temperature sensor with integrated fan control > national,lm92 =B10.33=B0C Accurate, 12-Bit + Sign Temperature Sensor an= d Thermal Window Comparator with Two-Wire Interface > nuvoton,npct501 i2c trusted platform module (TPM) > +nuvoton,npct6xx i2c trusted platform module (TPM) 6xx series > nxp,pca9556 Octal SMBus and I2C registered interface > nxp,pca9557 8-bit I2C-bus and SMBus I/O port with reset > nxp,pcf8563 Real-time clock/calendar > diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2= c_nuvoton.c > index b64effc..7fb0e6c 100644 > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -1,5 +1,5 @@ > /***********************************************************************= ******* > - * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501, > + * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501/NPCT6XX, > * based on the TCG TPM Interface Spec version 1.2. > * Specifications at www.trustedcomputinggroup.org > * > @@ -456,7 +456,7 @@ static bool i2c_nuvoton_req_canceled(struct tpm_chip = *chip, u8 status) > } > = > static const struct tpm_class_ops tpm_i2c =3D { > - .flags =3D TPM_OPS_AUTO_STARTUP, > + .flags =3D TPM_OPS_AUTO_STARTUP | TPM_OPS_PROBE_TPM2, > .status =3D i2c_nuvoton_read_status, > .recv =3D i2c_nuvoton_recv, > .send =3D i2c_nuvoton_send, > @@ -623,6 +623,7 @@ MODULE_DEVICE_TABLE(i2c, i2c_nuvoton_id); > static const struct of_device_id i2c_nuvoton_of_match[] =3D { > {.compatible =3D "nuvoton,npct501"}, > {.compatible =3D "winbond,wpct301"}, > + {.compatible =3D "nuvoton,npct6xx"}, > {}, > }; > MODULE_DEVICE_TABLE(of, i2c_nuvoton_of_match); > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 30aff5b..bc5fba3 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -524,7 +524,7 @@ static bool tpm_tis_req_canceled(struct tpm_chip *chi= p, u8 status) > } > = > static const struct tpm_class_ops tpm_tis =3D { > - .flags =3D TPM_OPS_AUTO_STARTUP, > + .flags =3D TPM_OPS_AUTO_STARTUP | TPM_OPS_PROBE_TPM2, > .status =3D tpm_tis_status, > .recv =3D tpm_tis_recv, > .send =3D tpm_tis_send, > -- = > 1.9.1 > = > this patch requires Jason's latest patch = Then you should create a proper patch set with a cover letter. /Jarkko ---------------------------------------------------------------------------= --- What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols ar= e = consuming the most bandwidth. Provides multi-vendor support for NetFlow, = J-Flow, sFlow and other flows. Make informed decisions using capacity = planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e