diff for duplicates of <20160603131009.456dc101@bbrezillon> diff --git a/a/1.txt b/N1/1.txt index b9b08f1..b5cc670 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -69,7 +69,7 @@ Rob Herring <robh@kernel.org> wrote: > > +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. > > + > > +Example: -> > +isc: isc at f0008000 { +> > +isc: isc@f0008000 { > > + compatible = "atmel,sama5d2-isc"; > > + reg = <0xf0008000 0x4000>; > > + interrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>; @@ -88,7 +88,7 @@ Rob Herring <robh@kernel.org> wrote: > > + }; > > + }; > > + -> > + isc_ispck: isc-ispck at 0 { +> > + isc_ispck: isc-ispck@0 { > > Drop the unit-address. You should only have one if you have a reg > property. @@ -98,7 +98,7 @@ Rob Herring <robh@kernel.org> wrote: > > + clocks = <&isc_clk>, <&iscck>; > > + }; > > + -> > + isc_mck: isc-mck at 1 { +> > + isc_mck: isc-mck@1 { > > ditto. > @@ -114,7 +114,7 @@ So I'd suggest dropping these clk sub-nodes, putting the #clock-cells, and clock-names properties in the isc node, and then referencing the isc node in you i2c device. -isc: isc at f0008000 { +isc: isc@f0008000 { compatible = "atmel,sama5d2-isc"; reg = <0xf0008000 0x4000>; interrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>; @@ -124,9 +124,9 @@ isc: isc at f0008000 { clock-output-names = "isc-mck"; }; -i2c1: i2c at fc028000 { +i2c1: i2c@fc028000 { /* ... */ - ov7740: camera at 21 { + ov7740: camera@21 { /* ... */ clocks = <&isc>; clock-names = "xvclk"; @@ -147,8 +147,8 @@ Rob, Songjun, would you agree on this representation? > > + }; > > +}; > > + -> > +i2c1: i2c at fc028000 { -> > + ov7740: camera at 21 { +> > +i2c1: i2c@fc028000 { +> > + ov7740: camera@21 { > > + compatible = "ovti,ov7740"; > > + reg = <0x21>; > > + @@ -169,7 +169,7 @@ Rob, Songjun, would you agree on this representation? > > _______________________________________________ > linux-arm-kernel mailing list -> linux-arm-kernel at lists.infradead.org +> linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index 2912223..deaed3b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,21 @@ "ref\01464677903-28412-1-git-send-email-songjun.wu@atmel.com\0" "ref\01464677903-28412-3-git-send-email-songjun.wu@atmel.com\0" "ref\020160602231609.GA24529@rob-hp-laptop\0" - "From\0boris.brezillon@free-electrons.com (Boris Brezillon)\0" - "Subject\0[PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver\0" + "From\0Boris Brezillon <boris.brezillon@free-electrons.com>\0" + "Subject\0Re: [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver\0" "Date\0Fri, 3 Jun 2016 13:10:09 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Rob Herring <robh@kernel.org>" + " Songjun Wu <songjun.wu@atmel.com>\0" + "Cc\0Mark Rutland <mark.rutland@arm.com>" + devicetree@vger.kernel.org + Pawel Moll <pawel.moll@arm.com> + Ian Campbell <ijc+devicetree@hellion.org.uk> + nicolas.ferre@atmel.com + linux-kernel@vger.kernel.org + laurent.pinchart@ideasonboard.com + Kumar Gala <galak@codeaurora.org> + g.liakhovetski@gmx.de + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2 Jun 2016 18:16:09 -0500\n" @@ -78,7 +89,7 @@ "> > +defined in Documentation/devicetree/bindings/media/video-interfaces.txt.\n" "> > +\n" "> > +Example:\n" - "> > +isc: isc at f0008000 {\n" + "> > +isc: isc@f0008000 {\n" "> > +\tcompatible = \"atmel,sama5d2-isc\";\n" "> > +\treg = <0xf0008000 0x4000>;\n" "> > +\tinterrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>;\n" @@ -97,7 +108,7 @@ "> > +\t\t};\n" "> > +\t};\n" "> > +\n" - "> > +\tisc_ispck: isc-ispck at 0 { \n" + "> > +\tisc_ispck: isc-ispck@0 { \n" "> \n" "> Drop the unit-address. You should only have one if you have a reg \n" "> property.\n" @@ -107,7 +118,7 @@ "> > +\t\tclocks = <&isc_clk>, <&iscck>;\n" "> > +\t};\n" "> > +\n" - "> > +\tisc_mck: isc-mck at 1 { \n" + "> > +\tisc_mck: isc-mck@1 { \n" "> \n" "> ditto.\n" "> \n" @@ -123,7 +134,7 @@ "and clock-names properties in the isc node, and then referencing the\n" "isc node in you i2c device.\n" "\n" - "isc: isc at f0008000 {\n" + "isc: isc@f0008000 {\n" "\tcompatible = \"atmel,sama5d2-isc\";\n" "\treg = <0xf0008000 0x4000>;\n" "\tinterrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>;\n" @@ -133,9 +144,9 @@ "\tclock-output-names = \"isc-mck\";\n" "};\n" "\n" - "i2c1: i2c at fc028000 {\n" + "i2c1: i2c@fc028000 {\n" "\t/* ... */\n" - "\tov7740: camera at 21 {\n" + "\tov7740: camera@21 {\n" "\t\t/* ... */\n" "\t\tclocks = <&isc>;\n" "\t\tclock-names = \"xvclk\";\n" @@ -156,8 +167,8 @@ "> > +\t};\n" "> > +};\n" "> > +\n" - "> > +i2c1: i2c at fc028000 {\n" - "> > +\tov7740: camera at 21 {\n" + "> > +i2c1: i2c@fc028000 {\n" + "> > +\tov7740: camera@21 {\n" "> > +\tcompatible = \"ovti,ov7740\";\n" "> > +\treg = <0x21>;\n" "> > +\n" @@ -178,7 +189,7 @@ "> \n" "> _______________________________________________\n" "> linux-arm-kernel mailing list\n" - "> linux-arm-kernel at lists.infradead.org\n" + "> linux-arm-kernel@lists.infradead.org\n" "> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel\n" "\n" "\n" @@ -188,4 +199,4 @@ "Embedded Linux and Kernel engineering\n" http://free-electrons.com -b1d6209af14ac9eecb029b0e6ced0b6e1de7e37703c87322d0c8ca0dc1b62cc0 +f97e646fb142ae076898da19ede5fbaa2fac8fb42a8c66423b9ad65e7cb4aa4b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.