From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932560AbcFCO37 (ORCPT ); Fri, 3 Jun 2016 10:29:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:50829 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbcFCO35 (ORCPT ); Fri, 3 Jun 2016 10:29:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,412,1459839600"; d="scan'208";a="821032197" Date: Fri, 3 Jun 2016 07:29:56 -0700 From: Andi Kleen To: "Dr. David Alan Gilbert" Cc: linux-kernel@vger.kernel.org Subject: Re: trace name copy/paste in native_write_msr ? Message-ID: <20160603142956.GU22049@tassilo.jf.intel.com> References: <20160603103250.GC2265@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160603103250.GC2265@work-vm> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2016 at 11:32:51AM +0100, Dr. David Alan Gilbert wrote: > Hi Andi, > In arch/x86/include/asm/msr.h native_write_msr(_safe) > you added a trace test in 7f47d8cc, should the > tracepoint_active's be testing for __tracepoint_write_msr ? Yes it should. Thanks for noticing. Please send a patch. -Andi