From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Fri, 3 Jun 2016 19:28:54 +0200 Subject: [PATCH] drm: sun4i: fix LPAE warnings In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> Message-ID: <20160603172854.GE21013@ulmo.ba.sec> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote: > When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns > into a 64-bit type, which causes warnings with some debug printks: > ================= > In file included from > drivers/gpu/drm/sun4i/sun4i_backend.c:13:: > drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer': > drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning: > format '%x' expects argument of type 'unsigned int', but argument 3 has > type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > ^ > include/drm/drmP.h:207:34: note: in definition of macro > 'DRM_DEBUG_DRIVER' > drm_ut_debug_printk(__func__, fmt, ##args); \ > ..... > > Use the proper printk format specifier [1] for dma_addr_t which takes > care of those differences. > > Signed-off-by: Andre Przywara > > [1] Documentation/printk-formats.txt > --- > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings Date: Fri, 3 Jun 2016 19:28:54 +0200 Message-ID: <20160603172854.GE21013@ulmo.ba.sec> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0445868253==" Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19AA56E1AE for ; Fri, 3 Jun 2016 17:28:58 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id n184so909520wmn.1 for ; Fri, 03 Jun 2016 10:28:58 -0700 (PDT) In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andre Przywara Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Maxime Ripard , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============0445868253== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2qXFWqzzG3v1+95a" Content-Disposition: inline --2qXFWqzzG3v1+95a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote: > When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns > into a 64-bit type, which causes warnings with some debug printks: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > In file included from > drivers/gpu/drm/sun4i/sun4i_backend.c:13:: > drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_= layer_buffer': > drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning: > format '%x' expects argument of type 'unsigned int', but argument 3 has > type 'dma_addr_t {aka long long unsigned int}' [-Wformat=3D] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > ^ > include/drm/drmP.h:207:34: note: in definition of macro > 'DRM_DEBUG_DRIVER' > drm_ut_debug_printk(__func__, fmt, ##args); \ > ..... >=20 > Use the proper printk format specifier [1] for dma_addr_t which takes > care of those differences. >=20 > Signed-off-by: Andre Przywara >=20 > [1] Documentation/printk-formats.txt > --- > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding --2qXFWqzzG3v1+95a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXUb5WAAoJEN0jrNd/PrOh6l0P/3T0Q2Rt+zMCsfguJlmPO8EJ h3Akd5AkATOVdUaMdXN46hhkWGVUutgVOgr20gIB+5wn+EFeD10YLh0pVQ7eBbu0 A+LmsIOA80vS/uiYptcvo7QgmmwwR+OkCuOjB1BjLkBRZiHDeK2rYJ3b5ZMYODV1 1wwSW7aFjnOdoL9FMIh32I0Hi5uVUdHTb3LdMJHKx3C2iwSb1DW9WRIt4vIZIZNO RYLxAvAGsG1Avh5VuOckXkxcquz1k/zfQzMvPed7j1MMjCOvGhNR5G2Fn3oWT9Vx JmiZsw8iJfVo/KOECq8BApM7u8VDGVfFrycOPEZinh3w/ulgrWsC++TMpn39aLuw XFsVfWfGpH2Mtuq/tggXdbgvXZHlgIS8far3s8wIFajX9doUddSFlRuLxahdHWVZ iZeh1PMeRTz3nrHUGkUlFo5ldWVDLXsvprevOvnrP6DlqmSXdSoLrEmlpAm+iOj0 qxas6W4OJNbKyxQo1+j7QKvddI3p63oKtOOggr6Gxw0J2jt9NqgXy1gX3ABd9Vok ARtyNjnNKYtZPLfA1/WWDBv30ZFqZjia7/6O5ERQfCNX+iCSQBF1cxNgsBgpX/km EU0mePHLlXd4iAlTRkmYAbCdcVGVGVYFj7Ne+ydyaJdM11VELuDFCbMn0tCP/PJE rxizckO+QRsmfDgExE6N =JGAj -----END PGP SIGNATURE----- --2qXFWqzzG3v1+95a-- --===============0445868253== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0445868253==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932851AbcFCR27 (ORCPT ); Fri, 3 Jun 2016 13:28:59 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35346 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136AbcFCR25 (ORCPT ); Fri, 3 Jun 2016 13:28:57 -0400 Date: Fri, 3 Jun 2016 19:28:54 +0200 From: Thierry Reding To: Andre Przywara Cc: Maxime Ripard , David Airlie , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun4i: fix LPAE warnings Message-ID: <20160603172854.GE21013@ulmo.ba.sec> References: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2qXFWqzzG3v1+95a" Content-Disposition: inline In-Reply-To: <1464973051-20432-1-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2qXFWqzzG3v1+95a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote: > When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns > into a 64-bit type, which causes warnings with some debug printks: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > In file included from > drivers/gpu/drm/sun4i/sun4i_backend.c:13:: > drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_= layer_buffer': > drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning: > format '%x' expects argument of type 'unsigned int', but argument 3 has > type 'dma_addr_t {aka long long unsigned int}' [-Wformat=3D] > DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); > ^ > include/drm/drmP.h:207:34: note: in definition of macro > 'DRM_DEBUG_DRIVER' > drm_ut_debug_printk(__func__, fmt, ##args); \ > ..... >=20 > Use the proper printk format specifier [1] for dma_addr_t which takes > care of those differences. >=20 > Signed-off-by: Andre Przywara >=20 > [1] Documentation/printk-formats.txt > --- > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding --2qXFWqzzG3v1+95a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXUb5WAAoJEN0jrNd/PrOh6l0P/3T0Q2Rt+zMCsfguJlmPO8EJ h3Akd5AkATOVdUaMdXN46hhkWGVUutgVOgr20gIB+5wn+EFeD10YLh0pVQ7eBbu0 A+LmsIOA80vS/uiYptcvo7QgmmwwR+OkCuOjB1BjLkBRZiHDeK2rYJ3b5ZMYODV1 1wwSW7aFjnOdoL9FMIh32I0Hi5uVUdHTb3LdMJHKx3C2iwSb1DW9WRIt4vIZIZNO RYLxAvAGsG1Avh5VuOckXkxcquz1k/zfQzMvPed7j1MMjCOvGhNR5G2Fn3oWT9Vx JmiZsw8iJfVo/KOECq8BApM7u8VDGVfFrycOPEZinh3w/ulgrWsC++TMpn39aLuw XFsVfWfGpH2Mtuq/tggXdbgvXZHlgIS8far3s8wIFajX9doUddSFlRuLxahdHWVZ iZeh1PMeRTz3nrHUGkUlFo5ldWVDLXsvprevOvnrP6DlqmSXdSoLrEmlpAm+iOj0 qxas6W4OJNbKyxQo1+j7QKvddI3p63oKtOOggr6Gxw0J2jt9NqgXy1gX3ABd9Vok ARtyNjnNKYtZPLfA1/WWDBv30ZFqZjia7/6O5ERQfCNX+iCSQBF1cxNgsBgpX/km EU0mePHLlXd4iAlTRkmYAbCdcVGVGVYFj7Ne+ydyaJdM11VELuDFCbMn0tCP/PJE rxizckO+QRsmfDgExE6N =JGAj -----END PGP SIGNATURE----- --2qXFWqzzG3v1+95a--