From: Matthew Hall <mhall@mhcomputing.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
"Wiles, Keith" <keith.wiles@intel.com>,
Panu Matilainen <pmatilai@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [RFC] Yet another option for DPDK options
Date: Fri, 3 Jun 2016 14:38:48 -0700 [thread overview]
Message-ID: <20160603213848.GA16022@mhcomputing.net> (raw)
In-Reply-To: <CAKy9EB2imz7S6h_UY2U9_V9iU5mvncfQRb3RGs+Uz9+ct5_10Q@mail.gmail.com>
On Fri, Jun 03, 2016 at 09:52:40PM +0300, Arnon Warshavsky wrote:
> What about the data types of the values?
> I would assume that as a library it can provide the service of typed
> get/set and not leave conversion and validation to the app.
>
> rte_map_get_int(map,section,key)
> rte_map_get_double(...)
> rte_map_get_string(...)
> rte_map_get_bytes(...,destBuff , destBuffSize) //e.g byte array of RSS key
>
> This may also allow some basic validity of the configuration file
>
> Another point I forgot about is default values.
> We sometimes use a notation where the app also specifies a default value in
> case the configuration did not specify it
> rte_map_get_int(map,section,key , defaultValue )
> and specify if this was a mandatory that has no default
> rte_map_get_int_crash_if_missing (map,section,key)
This is why I was advising to use something similar to json-c's API with some
type specific functions to make things easier for the users, with the
dot-terminated naming made popular by sysctl such as
"debug.intel.ctr_KMD_CTR_RPUPEI" and so forth.
> /Arnon
Matthew
next prev parent reply other threads:[~2016-06-03 21:38 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 15:00 [RFC] Yet another option for DPDK options Wiles, Keith
2016-06-01 15:46 ` Matthew Hall
2016-06-01 16:08 ` Wiles, Keith
2016-06-01 15:58 ` Jay Rolette
2016-06-01 16:18 ` Bruce Richardson
2016-06-01 16:21 ` Arnon Warshavsky
2016-06-01 18:13 ` Wiles, Keith
2016-06-01 18:31 ` Stephen Hemminger
2016-06-03 10:07 ` Yerden Zhumabekov
2016-06-01 18:51 ` Thomas Monjalon
2016-06-02 9:19 ` Marc
2016-06-02 7:56 ` Yuanhan Liu
2016-06-02 10:41 ` Neil Horman
2016-06-02 13:19 ` Thomas Monjalon
2016-06-02 13:53 ` Wiles, Keith
2016-06-02 17:11 ` Neil Horman
2016-06-02 19:33 ` Wiles, Keith
2016-06-02 19:41 ` Wiles, Keith
2016-06-02 20:08 ` Neil Horman
2016-06-02 20:53 ` Matthew Hall
2016-06-02 22:34 ` Neil Horman
2016-06-03 2:17 ` Matthew Hall
2016-06-03 9:57 ` Bruce Richardson
2016-06-03 10:06 ` Bruce Richardson
2016-06-03 12:03 ` Neil Horman
2016-06-03 10:29 ` Bruce Richardson
2016-06-03 11:01 ` Bruce Richardson
2016-06-03 11:50 ` Neil Horman
2016-06-03 12:01 ` Arnon Warshavsky
2016-06-03 12:53 ` Panu Matilainen
2016-06-03 14:31 ` Arnon Warshavsky
2016-06-03 16:04 ` Wiles, Keith
2016-06-03 16:10 ` Wiles, Keith
2016-06-03 17:44 ` Neil Horman
2016-06-03 18:29 ` Wiles, Keith
2016-06-03 18:38 ` Neil Horman
2016-06-03 18:52 ` Arnon Warshavsky
2016-06-03 19:00 ` Wiles, Keith
2016-06-03 19:07 ` Wiles, Keith
2016-06-03 19:18 ` Neil Horman
2016-06-03 19:23 ` Wiles, Keith
2016-06-03 19:28 ` Arnon Warshavsky
2016-06-03 21:42 ` Matthew Hall
2016-06-03 21:41 ` Matthew Hall
2016-06-05 0:19 ` Neil Horman
2016-06-03 21:40 ` Matthew Hall
2016-06-03 21:38 ` Matthew Hall [this message]
2016-06-03 12:14 ` Panu Matilainen
2016-06-02 20:51 ` Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603213848.GA16022@mhcomputing.net \
--to=mhall@mhcomputing.net \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=keith.wiles@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=pmatilai@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.