From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] reservation: sprinkle some WARN_ON()s Date: Sat, 4 Jun 2016 14:52:46 +0200 Message-ID: <20160604125245.GG14529@phenom.ffwll.local> References: <1459456012-16248-2-git-send-email-robdclark@gmail.com> <1460076776-25023-1-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FFC36E232 for ; Sat, 4 Jun 2016 12:52:50 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id n184so5263460wmn.1 for ; Sat, 04 Jun 2016 05:52:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1460076776-25023-1-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMDcsIDIwMTYgYXQgMDg6NTI6NTZQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEEgYml0IG92ZXJraWxsIHNpbmNlLCBmb3IgZXhhbXBsZSwgdGhlIHJjdV9kZXJlZmVyZW5j ZV9wcm90ZWN0ZWQoKSBpbgo+IHJlc2VydmF0aW9uX29iamVjdF9nZXRfbGlzdCgpIHdpbGwgV0FS Ti4gIEJ1dCB0aGlzIGlzIG11Y2ggbGVzcyBzdWJ0bGUKPiBmb3IgZm9sa3MgcmVhZGluZyB0aGUg Y29kZS4KPiAKPiB2MjogdXNlIHJlc2VydmF0aW9uX29iamVjdF9oZWxkKCkgaW5zdGVhZCBvZiB3 d19tdXRleF9pc19sb2NrZWQoKQo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNs YXJrQGdtYWlsLmNvbT4KCkRvZXNuJ3Qgc2VlbSB0byBidWlsZCBoZXJlOgoKCkluIGZpbGUgaW5j bHVkZWQgZnJvbSAuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2J1Zy5oOjU5OjAsCiAgICAgICAgICAg ICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4L2J1Zy5oOjQsCiAgICAgICAgICAgICAgICAgZnJvbSBp bmNsdWRlL2xpbnV4L3RocmVhZF9pbmZvLmg6MTEsCiAgICAgICAgICAgICAgICAgZnJvbSBpbmNs dWRlL2FzbS1nZW5lcmljL2N1cnJlbnQuaDo0LAogICAgICAgICAgICAgICAgIGZyb20gYXJjaC9h cm0vaW5jbHVkZS9nZW5lcmF0ZWQvYXNtL2N1cnJlbnQuaDoxLAogICAgICAgICAgICAgICAgIGZy b20gaW5jbHVkZS9saW51eC9tdXRleC5oOjEzLAogICAgICAgICAgICAgICAgIGZyb20gaW5jbHVk ZS9saW51eC93d19tdXRleC5oOjE3LAogICAgICAgICAgICAgICAgIGZyb20gaW5jbHVkZS9saW51 eC9yZXNlcnZhdGlvbi5oOjQyLAogICAgICAgICAgICAgICAgIGZyb20gZHJpdmVycy9kbWEtYnVm L3Jlc2VydmF0aW9uLmM6MzU6CmRyaXZlcnMvZG1hLWJ1Zi9yZXNlcnZhdGlvbi5jOiBJbiBmdW5j dGlvbiDigJhyZXNlcnZhdGlvbl9vYmplY3RfcmVzZXJ2ZV9zaGFyZWTigJk6CmluY2x1ZGUvbGlu dXgvcmVzZXJ2YXRpb24uaDo4MjozODogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1 bmN0aW9uIOKAmGxvY2tkZXBfaXNfaGVsZOKAmSBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1k ZWNsYXJhdGlvbl0KICNkZWZpbmUgcmVzZXJ2YXRpb25fb2JqZWN0X2hlbGQob2JqKSBsb2NrZGVw X2lzX2hlbGQoJihvYmopLT5sb2NrLmJhc2UpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXgppbmNsdWRlL2FzbS1nZW5lcmljL2J1Zy5oOjkyOjI1OiBub3RlOiBpbiBkZWZp bml0aW9uIG9mIG1hY3JvIOKAmFdBUk5fT07igJkKICBpbnQgX19yZXRfd2Fybl9vbiA9ICEhKGNv bmRpdGlvbik7ICAgIFwKICAgICAgICAgICAgICAgICAgICAgICAgIF4KZHJpdmVycy9kbWEtYnVm L3Jlc2VydmF0aW9uLmM6NzQ6MTE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhyZXNl cnZhdGlvbl9vYmplY3RfaGVsZOKAmQogIFdBUk5fT04oIXJlc2VydmF0aW9uX29iamVjdF9oZWxk KG9iaikpOwoKU291bmRzIGxpa2Ugd2Ugc2hvdWxkIGluY2x1ZGUgc29tZSBoZWFkZXJzIGZyb20g cmVzZXJ2YXRpb24uaC4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0 aW9uLmMgfCA2ICsrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi9yZXNlcnZhdGlvbi5jIGIvZHJpdmVycy9kbWEt YnVmL3Jlc2VydmF0aW9uLmMKPiBpbmRleCBjMGJkNTcyLi40MzlhZjgyIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZG1hLWJ1Zi9yZXNlcnZhdGlvbi5jCj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3Jl c2VydmF0aW9uLmMKPiBAQCAtNTIsNiArNTIsOCBAQCBpbnQgcmVzZXJ2YXRpb25fb2JqZWN0X3Jl c2VydmVfc2hhcmVkKHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKm9iaikKPiAgCXN0cnVjdCBy ZXNlcnZhdGlvbl9vYmplY3RfbGlzdCAqZm9iaiwgKm9sZDsKPiAgCXUzMiBtYXg7Cj4gIAo+ICsJ V0FSTl9PTighcmVzZXJ2YXRpb25fb2JqZWN0X2hlbGQob2JqKSk7Cj4gKwo+ICAJb2xkID0gcmVz ZXJ2YXRpb25fb2JqZWN0X2dldF9saXN0KG9iaik7Cj4gIAo+ICAJaWYgKG9sZCAmJiBvbGQtPnNo YXJlZF9tYXgpIHsKPiBAQCAtMTg5LDYgKzE5MSw4IEBAIHZvaWQgcmVzZXJ2YXRpb25fb2JqZWN0 X2FkZF9zaGFyZWRfZmVuY2Uoc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCAqb2JqLAo+ICB7Cj4g IAlzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0X2xpc3QgKm9sZCwgKmZvYmogPSBvYmotPnN0YWdl ZDsKPiAgCj4gKwlXQVJOX09OKCFyZXNlcnZhdGlvbl9vYmplY3RfaGVsZChvYmopKTsKPiArCj4g IAlvbGQgPSByZXNlcnZhdGlvbl9vYmplY3RfZ2V0X2xpc3Qob2JqKTsKPiAgCW9iai0+c3RhZ2Vk ID0gTlVMTDsKPiAgCj4gQEAgLTIwNyw2ICsyMTEsOCBAQCB2b2lkIHJlc2VydmF0aW9uX29iamVj dF9hZGRfZXhjbF9mZW5jZShzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpvYmosCj4gIAlzdHJ1 Y3QgcmVzZXJ2YXRpb25fb2JqZWN0X2xpc3QgKm9sZDsKPiAgCXUzMiBpID0gMDsKPiAgCj4gKwlX QVJOX09OKCFyZXNlcnZhdGlvbl9vYmplY3RfaGVsZChvYmopKTsKPiArCj4gIAlvbGQgPSByZXNl cnZhdGlvbl9vYmplY3RfZ2V0X2xpc3Qob2JqKTsKPiAgCWlmIChvbGQpCj4gIAkJaSA9IG9sZC0+ c2hhcmVkX2NvdW50Owo+IC0tIAo+IDIuNS41Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==