From: Greg KH <gregkh@linuxfoundation.org>
To: Jyoti Singh <jssengar92@gmail.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Jyoti Singh <jssengar@gmail.com>
Subject: Re: [PATCH] char: Prefer pr_* instead of printk
Date: Sat, 4 Jun 2016 09:36:40 -0700 [thread overview]
Message-ID: <20160604163640.GA6559@kroah.com> (raw)
In-Reply-To: <1465051511-10758-1-git-send-email-jssengar92@gmail.com>
On Sat, Jun 04, 2016 at 08:15:11PM +0530, Jyoti Singh wrote:
> This patch replaces all the printk[KERN_INFO] with pr_* in the file
> "ttyprintk.c" addressing the following warning:
>
> WARNING:Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
> then dev_info(dev,... then pr_info(... to printk(KERN_INFO ...
> Found with checkpatch
Sometimes checkpatch tells you to do things that are incorrect :)
Are you _sure_ the code works the same before and after this? The
ttyprintk driver is a bit "special".
Did you test these changes?
thanks,
greg k-h
next prev parent reply other threads:[~2016-06-04 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 14:45 [PATCH] char: Prefer pr_* instead of printk Jyoti Singh
2016-06-04 16:36 ` Greg KH [this message]
[not found] ` <CADAjwjQq5u2LYeOQa-L5BJ40hTYcp-23PiBLLHABznVhvkHRUg@mail.gmail.com>
[not found] ` <20160605150322.GB14267@kroah.com>
[not found] ` <CADAjwjSiztcEVMrZEAj34QJK+sn6E8P98edE8Y7=udXYfYWv_g@mail.gmail.com>
2016-06-06 6:14 ` jyoti singh
2016-06-06 14:30 ` Greg KH
2016-06-06 15:23 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604163640.GA6559@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jssengar92@gmail.com \
--cc=jssengar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.