All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Salah Triki <salah.triki@acm.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real error
Date: Sat, 4 Jun 2016 20:37:11 +0100	[thread overview]
Message-ID: <20160604193711.GC14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <e675d6c7c8645d37070610993e400239dba22680.1465065995.git.salah.triki@acm.org>

On Sat, Jun 04, 2016 at 07:53:19PM +0100, Salah Triki wrote:
> File not found is not an error and lookup must return error code only
> on real error, otherwise creating inodes with functions like create,
> mkdir and so on will fail.

You do realize that befs is read-only and doesn't have ->mkdir() and friends,
right?  Patch is almost correct (you want d_add(dentry, NULL) if you go
that way, or you'll be calling ->lookup() ever time anyway), but it doesn't
make much sense on its own.

      parent reply	other threads:[~2016-06-04 19:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 18:53 [PATCH 1/3] fs: befs: Lookup must return error code only on real error Salah Triki
2016-06-04 18:53 ` [PATCH 2/3] fs: befs: Insert NULL inode to dentry Salah Triki
2016-06-04 18:53 ` [PATCH 3/3] fs: befs: Increment i_count when inode is found Salah Triki
2016-06-04 19:14   ` kbuild test robot
2016-06-04 19:32   ` Al Viro
2016-06-04 20:03     ` Salah Triki
2016-06-04 19:37 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160604193711.GC14480@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=salah.triki@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.