From: Wolfram Sang <wsa@the-dreams.de>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Corey Minyard <minyard@acm.org>,
Jean Delvare <jdelvare@suse.de>,
Guenter Roeck <linux@roeck-us.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>,
Christopher Heiny <cheiny@synaptics.com>,
linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7 3/4] i2c: i801: add support of Host Notify
Date: Sun, 5 Jun 2016 09:25:41 +0200 [thread overview]
Message-ID: <20160605072541.GE2722@katana> (raw)
In-Reply-To: <1464688985-19102-4-git-send-email-benjamin.tissoires@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Tue, May 31, 2016 at 12:03:04PM +0200, Benjamin Tissoires wrote:
> The i801 chip can handle the Host Notify feature since ICH 3 as mentioned
> in http://www.intel.com/content/dam/doc/datasheet/82801ca-io-controller-hub-3-datasheet.pdf
>
> Enable the functionality unconditionally and propagate the alert
> on each notification.
>
> With a T440s and a Synaptics touchpad that implements Host Notify, the
> payload data is always 0x0000, so I am not sure if the device actually
> sends the payload or if there is a problem regarding the implementation.
>
> Tested-by: Andrew Duggan <aduggan@synaptics.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Did some high level review. Did not dig into datasheets.
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-05 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 10:03 [PATCH v7 0/4] i2c-smbus: add support for HOST NOTIFY Benjamin Tissoires
2016-05-31 10:03 ` [PATCH v7 1/4] i2c: add a protocol parameter to the alert callback Benjamin Tissoires
2016-06-05 7:17 ` Wolfram Sang
2016-05-31 10:03 ` [PATCH v7 2/4] i2c-smbus: add SMBus Host Notify support Benjamin Tissoires
2016-06-05 7:23 ` Wolfram Sang
2016-05-31 10:03 ` [PATCH v7 3/4] i2c: i801: add support of Host Notify Benjamin Tissoires
2016-06-05 7:25 ` Wolfram Sang [this message]
2016-05-31 10:03 ` [PATCH v7 4/4] Input: synaptics-rmi4 - add SMBus support Benjamin Tissoires
2016-06-05 7:13 ` [PATCH v7 0/4] i2c-smbus: add support for HOST NOTIFY Wolfram Sang
2016-06-07 14:01 ` Benjamin Tissoires
2016-06-07 14:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160605072541.GE2722@katana \
--to=wsa@the-dreams.de \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cheiny@synaptics.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.