From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1b9qU8-0008Vv-Cx
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:06:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1b9qU2-0007Q4-8Z
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:06:11 -0400
Received: from mga02.intel.com ([134.134.136.20]:11748)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1b9qU2-0007Pn-2L
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:06:06 -0400
Date: Mon, 6 Jun 2016 17:06:49 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20160606090649.GA30154@yliu-dev.sh.intel.com>
References: <1462896240-30999-1-git-send-email-marcandre.lureau@redhat.com>
	<1462896240-30999-8-git-send-email-marcandre.lureau@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1462896240-30999-8-git-send-email-marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user
 acked features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>, Ilya Maximets <i.maximets@samsung.com>, jonshin@cisco.com, Tetsuya Mukawa <mukawa@igel.co.jp>

On Tue, May 10, 2016 at 06:03:57PM +0200, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The initial vhost-user connection sets the features to be negotiated
> with the driver. Renegotiation isn't possible without device reset.
> 
> To handle reconnection of vhost-user backend, ensure the same set of
> features are provided, and reuse already acked features.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/net/vhost_net.c       | 21 ++++++++++++++++++++-
>  include/net/vhost-user.h |  1 +
>  include/net/vhost_net.h  |  3 +++
>  net/vhost-user.c         | 10 ++++++++++
>  4 files changed, 34 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 805a0df..f3df18c 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -120,6 +120,11 @@ uint64_t vhost_net_get_max_queues(VHostNetState *net)
>      return net->dev.max_queues;
>  }
>  
> +uint64_t vhost_net_get_acked_features(VHostNetState *net)
> +{
> +    return net->dev.acked_features;
> +}

Note that you need add a dummy implementation for !VHOST_NET. Otherwise,
build won't work.

And sorry for being noisy, here is another ping about the status of
this patch set.

	--yliu