From: Pavel Machek <pavel@ucw.cz>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vinod Koul <vinod.koul@intel.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] PM / clk: export symbols for existing pm_clk_<...> API fcns
Date: Mon, 6 Jun 2016 12:16:47 +0200 [thread overview]
Message-ID: <20160606101647.GA22028@amd> (raw)
In-Reply-To: <1465149495-22961-1-git-send-email-paul.gortmaker@windriver.com>
On Sun 2016-06-05 13:58:15, Paul Gortmaker wrote:
> While trying to convert a DMA driver from bool to tristate, we
> encountered the following:
>
> ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined!
>
> Since in principle there is nothing preventing these functions
> from being used in modular code as well as builtin, we add the
> export of them. We expand the scope to also include:
>
> pm_clk_add
> of_pm_clk_add_clks
> pm_clk_remove
> pm_clk_remove_clk
> pm_clk_init
> pm_clk_runtime_suspend
> pm_clk_runtime_resume
> pm_clk_add_notifier
>
> ...since these functions are also non-static and presumably form
> part of the existing API used by other drivers that may become
> modular in the future.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-06 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 17:58 [PATCH] PM / clk: export symbols for existing pm_clk_<...> API fcns Paul Gortmaker
2016-06-05 17:58 ` Paul Gortmaker
2016-06-06 10:16 ` Pavel Machek [this message]
2016-06-16 14:04 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606101647.GA22028@amd \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rjw@rjwysocki.net \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.