From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/14] drm/amdgpu: use drm_crtc_vblank_{get,put}() Date: Mon, 6 Jun 2016 18:06:31 +0200 Message-ID: <20160606160631.GC10110@phenom.ffwll.local> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-8-git-send-email-gustavo@padovan.org> <20160606153526.GB2529@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF5866E5EC for ; Mon, 6 Jun 2016 16:06:36 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id n184so17651965wmn.1 for ; Mon, 06 Jun 2016 09:06:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160606153526.GB2529@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Alex Deucher , Maling list - DRI developers , Michel =?iso-8859-1?Q?D=E4nzer?= , open list , Alex Deucher , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdW4gMDYsIDIwMTYgYXQgMTI6MzU6MjZQTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IDIwMTYtMDYtMDYgQWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+ Ogo+IAo+ID4gT24gTW9uLCBKdW4gNiwgMjAxNiBhdCAxMDo0MSBBTSwgR3VzdGF2byBQYWRvdmFu IDxndXN0YXZvQHBhZG92YW4ub3JnPiB3cm90ZToKPiA+ID4gRnJvbTogR3VzdGF2byBQYWRvdmFu IDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+ID4gPgo+ID4gPiBSZXBsYWNlIHRo ZSBsZWdhY3kgZHJtX3ZibGFua197Z2V0LHB1dH0oKSB3aXRoIHRoZSBuZXcgaGVscGVyIGZ1bmN0 aW9ucy4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZv LnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+ID4gCj4gPiBUaGlzIGFuZCB0aGUgcmFkZW9uIHBh dGNoIGFyZToKPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4KPiA+IAo+ID4gU2hvdWxkIEkgcGljayB0aGlzIHVwLCBvciBhcmUgeW91 IHBsYW5uaW5nIHRvIHVwc3RyZWFtIHRoaXMgYXMgYSBiaWcgYmF0Y2g/Cj4gCj4gSSB3b3VsZCBs aWtlIHRvIHVwc3RyZWFtIGFzIGEgYmlnIGJhdGNoIHZpYSBkcm0tbWlzYy4gSWYgSSBnZXQgYWNr cyBvbgo+IGV2ZXJ5dGhpbmcgaXQgd291bGQgYmUgcG9zc2libGUgdG8gcmVtb3ZlIGRybV92Ymxh bmtfZ2V0LHB1dCBmb3IgNC44LgoKT2ssIEkgdmFjdXVtZWQgdGhlbSBhbGwgdXAgZXhjZXB0IGZv ciB0aGUgMiBub3V2ZWF1IHBhdGNoZXMgYW5kIHRoZSBjb3JlCnBhdGNoIHRvIHJlbW92ZSBkcm1f c2VuZF92YmxhbmtfZXZlbnQuIEJ0dyBkcm1fYXJtX3ZibGFua19ldmVudCBwcm9iYWJseQpkZXNl cnZlcyB0aGUgc2FtZSB0cmVhdG1lbnQgKGFuZCB3b3VsZCBnZXQgcmlkIG9mIGRybV9jcnRjX2lu ZGV4IGZyb20Kbm91dmVhdSkuCi1EYW5pZWwKCj4gCj4gCUd1c3Rhdm8KPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVy ClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5j aApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbcFFQGh (ORCPT ); Mon, 6 Jun 2016 12:06:37 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32996 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbcFFQGg (ORCPT ); Mon, 6 Jun 2016 12:06:36 -0400 Date: Mon, 6 Jun 2016 18:06:31 +0200 From: Daniel Vetter To: Gustavo Padovan , Alex Deucher , Maling list - DRI developers , Michel =?iso-8859-1?Q?D=E4nzer?= , open list , Alex Deucher , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 08/14] drm/amdgpu: use drm_crtc_vblank_{get,put}() Message-ID: <20160606160631.GC10110@phenom.ffwll.local> Mail-Followup-To: Gustavo Padovan , Alex Deucher , Maling list - DRI developers , Michel =?iso-8859-1?Q?D=E4nzer?= , open list , Alex Deucher , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-8-git-send-email-gustavo@padovan.org> <20160606153526.GB2529@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606153526.GB2529@joana> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 12:35:26PM -0300, Gustavo Padovan wrote: > 2016-06-06 Alex Deucher : > > > On Mon, Jun 6, 2016 at 10:41 AM, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Replace the legacy drm_vblank_{get,put}() with the new helper functions. > > > > > > Signed-off-by: Gustavo Padovan > > > > This and the radeon patch are: > > > > Reviewed-by: Alex Deucher > > > > Should I pick this up, or are you planning to upstream this as a big batch? > > I would like to upstream as a big batch via drm-misc. If I get acks on > everything it would be possible to remove drm_vblank_get,put for 4.8. Ok, I vacuumed them all up except for the 2 nouveau patches and the core patch to remove drm_send_vblank_event. Btw drm_arm_vblank_event probably deserves the same treatment (and would get rid of drm_crtc_index from nouveau). -Daniel > > Gustavo > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch