From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Mateusz Guzik <mguzik@redhat.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] Save dump_root into pid_namespace
Date: Mon, 6 Jun 2016 18:02:42 +0100 [thread overview]
Message-ID: <20160606170242.GD14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <80f929b266dd3ac6ad5f5d9955f393b0f1f8120f.1465214472.git.zhaolei@cn.fujitsu.com>
On Mon, Jun 06, 2016 at 08:02:08PM +0800, Zhao Lei wrote:
> + spin_lock(&pid_ns->root_for_dump_lock);
> +
> + if (pid_ns->root_for_dump.mnt)
> + path_put(&pid_ns->root_for_dump);
NAK, for obvious reasons - don't do blocking operations under spinlocks,
for starters.
next prev parent reply other threads:[~2016-06-06 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:02 [PATCH 0/3] Write dump into container's filesystem for pipe_type core_pattern Zhao Lei
2016-06-06 12:02 ` Zhao Lei
[not found] ` <cover.1465214472.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-06-06 12:02 ` [PATCH 1/3] Save dump_root into pid_namespace Zhao Lei
2016-06-06 12:02 ` Zhao Lei
2016-06-06 17:02 ` Al Viro [this message]
[not found] ` <80f929b266dd3ac6ad5f5d9955f393b0f1f8120f.1465214472.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-06-06 17:02 ` Al Viro
2016-06-06 12:02 ` [PATCH 2/3] Make dump_pipe thread possilbe to select the rootfs Zhao Lei
2016-06-06 12:02 ` Zhao Lei
2016-06-06 12:02 ` [PATCH 3/3] Write dump into container's filesystem for pipe_type core_pattern Zhao Lei
2016-06-06 12:02 ` Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606170242.GD14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.