From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Vishwanath Pai <vpai@akamai.com>
Cc: kaber@trash.net, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
johunt@akamai.com, netdev@vger.kernel.org,
pai.vishwain@gmail.com
Subject: Re: [PATCH] netfilter/nflog: nflog-range does not truncate packets
Date: Tue, 7 Jun 2016 00:31:06 +0200 [thread overview]
Message-ID: <20160606223106.GA1621@salvia> (raw)
In-Reply-To: <20160602002354.GG1644@akamai.com>
On Wed, Jun 01, 2016 at 08:23:54PM -0400, Vishwanath Pai wrote:
> netfilter/nflog: nflog-range does not truncate packets
>
> The --nflog-range parameter from userspace is ignored in the kernel and
> the entire packet is sent to the userspace. The per-instance parameter
> copy_range still works, with this change --nflog-range will have
> preference over copy_range.
I think it's reasonable to assume that --nflog-range from the rule
applies globally to any instance.
However, per-instance copy_range has prevailed over --nflog-range
since the beginning, so I would follow a more conservative approach,
ie. remain copy_range in preference over --nflog-range.
So I'd suggest you invert this logic.
Let me know, thanks.
next prev parent reply other threads:[~2016-06-06 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 0:23 [PATCH] netfilter/nflog: nflog-range does not truncate packets Vishwanath Pai
2016-06-06 22:31 ` Pablo Neira Ayuso [this message]
2016-06-07 23:06 ` Vishwanath Pai
2016-06-08 12:16 ` Pablo Neira Ayuso
2016-06-09 17:57 ` Vishwanath Pai
2016-06-13 3:40 ` Vishwanath Pai
2016-06-15 12:39 ` Pablo Neira Ayuso
2016-06-15 14:55 ` Vishwanath Pai
2016-06-15 15:13 ` Lubashev, Igor
2016-06-17 11:22 ` Pablo Neira Ayuso
2016-06-17 15:43 ` Vishwanath Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606223106.GA1621@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pai.vishwain@gmail.com \
--cc=vpai@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.