All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksei Mamlin <mamlinav@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>, Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Date: Mon, 6 Jun 2016 22:59:03 +0300	[thread overview]
Message-ID: <20160606225903.264abc01647eb1528cc226bd@gmail.com> (raw)
In-Reply-To: <20160606205549.1ecd6fdb@bbrezillon>

On Mon, 6 Jun 2016 20:55:49 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon,  6 Jun 2016 13:24:22 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > mode in controller drivers.
> 
> Still hoping to get this series [1] merged in 4.8, but if that's
> not the case, I'll apply your patch.
> 
> BTW, that would be great if you could test it on your platforms.
> 

It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
chip:

[    0.886153] nand: Could not find valid ONFI parameter page; aborting
[    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.899025] nand: Hynix 1c03000.nand
[    0.902596] nand: bus width 8 instead 16 bit
[    0.906858] nand: No NAND device found
[    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
[    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

> 
> Regards,
> 
> Boris
> 
> [1]https://lkml.org/lkml/2016/5/27/264
> 
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> >  drivers/mtd/nand/nand_ids.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> > index ccc05f5..ccdc773 100644
> > --- a/drivers/mtd/nand/nand_ids.c
> > +++ b/drivers/mtd/nand/nand_ids.c
> > @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
> >  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
> >  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> >  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> > +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> > +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> > +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> > +		  NAND_ECC_INFO(40, SZ_1K), 0 },
> >  
> >  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
> >  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> 
> 
> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

WARNING: multiple messages have this Message-ID (diff)
From: mamlinav@gmail.com (Aleksei Mamlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Date: Mon, 6 Jun 2016 22:59:03 +0300	[thread overview]
Message-ID: <20160606225903.264abc01647eb1528cc226bd@gmail.com> (raw)
In-Reply-To: <20160606205549.1ecd6fdb@bbrezillon>

On Mon, 6 Jun 2016 20:55:49 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon,  6 Jun 2016 13:24:22 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > mode in controller drivers.
> 
> Still hoping to get this series [1] merged in 4.8, but if that's
> not the case, I'll apply your patch.
> 
> BTW, that would be great if you could test it on your platforms.
> 

It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
chip:

[    0.886153] nand: Could not find valid ONFI parameter page; aborting
[    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.899025] nand: Hynix 1c03000.nand
[    0.902596] nand: bus width 8 instead 16 bit
[    0.906858] nand: No NAND device found
[    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
[    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

> 
> Regards,
> 
> Boris
> 
> [1]https://lkml.org/lkml/2016/5/27/264
> 
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> >  drivers/mtd/nand/nand_ids.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> > index ccc05f5..ccdc773 100644
> > --- a/drivers/mtd/nand/nand_ids.c
> > +++ b/drivers/mtd/nand/nand_ids.c
> > @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
> >  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
> >  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> >  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> > +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> > +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> > +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> > +		  NAND_ECC_INFO(40, SZ_1K), 0 },
> >  
> >  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
> >  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> 
> 
> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

WARNING: multiple messages have this Message-ID (diff)
From: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Boris Brezillon
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Brian Norris
	<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Date: Mon, 6 Jun 2016 22:59:03 +0300	[thread overview]
Message-ID: <20160606225903.264abc01647eb1528cc226bd@gmail.com> (raw)
In-Reply-To: <20160606205549.1ecd6fdb@bbrezillon>

On Mon, 6 Jun 2016 20:55:49 +0200
Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> On Mon,  6 Jun 2016 13:24:22 +0300
> Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
> > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > mode in controller drivers.
> 
> Still hoping to get this series [1] merged in 4.8, but if that's
> not the case, I'll apply your patch.
> 
> BTW, that would be great if you could test it on your platforms.
> 

It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
chip:

[    0.886153] nand: Could not find valid ONFI parameter page; aborting
[    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.899025] nand: Hynix 1c03000.nand
[    0.902596] nand: bus width 8 instead 16 bit
[    0.906858] nand: No NAND device found
[    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
[    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

> 
> Regards,
> 
> Boris
> 
> [1]https://lkml.org/lkml/2016/5/27/264
> 
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  drivers/mtd/nand/nand_ids.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> > index ccc05f5..ccdc773 100644
> > --- a/drivers/mtd/nand/nand_ids.c
> > +++ b/drivers/mtd/nand/nand_ids.c
> > @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
> >  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
> >  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> >  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> > +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> > +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> > +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> > +		  NAND_ECC_INFO(40, SZ_1K), 0 },
> >  
> >  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
> >  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> 
> 
> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

  reply	other threads:[~2016-06-06 19:59 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
2016-06-06 10:24 ` Aleksei Mamlin
2016-06-06 10:24 ` Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-08 22:04   ` Maxime Ripard
2016-06-08 22:04     ` Maxime Ripard
2016-06-08 22:04     ` Maxime Ripard
2016-06-06 10:24 ` [PATCH 2/7] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 3/7] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-07 17:21   ` Aleksei Mamlin
2016-06-07 17:21     ` Aleksei Mamlin
2016-06-07 17:21     ` Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 18:55   ` Boris Brezillon
2016-06-06 18:55     ` Boris Brezillon
2016-06-06 18:55     ` Boris Brezillon
2016-06-06 19:59     ` Aleksei Mamlin [this message]
2016-06-06 19:59       ` Aleksei Mamlin
2016-06-06 19:59       ` Aleksei Mamlin
2016-06-06 20:31       ` Boris Brezillon
2016-06-06 20:31         ` Boris Brezillon
2016-06-06 20:31         ` Boris Brezillon
2016-06-06 21:06         ` Aleksei Mamlin
2016-06-06 21:06           ` Aleksei Mamlin
2016-06-06 21:06           ` Aleksei Mamlin
2016-06-07  5:48           ` Boris Brezillon
2016-06-07  5:48             ` Boris Brezillon
2016-06-07  5:48             ` Boris Brezillon
2016-06-07  5:49         ` Boris Brezillon
2016-06-07  5:49           ` Boris Brezillon
2016-06-06 10:24 ` [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 18:50   ` Boris Brezillon
2016-06-06 18:50     ` Boris Brezillon
2016-06-06 18:50     ` Boris Brezillon
2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 10:24   ` Aleksei Mamlin
2016-06-06 18:51   ` Boris Brezillon
2016-06-06 18:51     ` Boris Brezillon
2016-06-08 22:03   ` Maxime Ripard
2016-06-08 22:03     ` Maxime Ripard
2016-06-08 22:03     ` Maxime Ripard
2016-06-09  8:11     ` Aleksei Mamlin
2016-06-09  8:11       ` Aleksei Mamlin
2016-06-09  8:11       ` Aleksei Mamlin
2016-06-10  8:56       ` Maxime Ripard
2016-06-10  8:56         ` Maxime Ripard
2016-06-10  8:56         ` Maxime Ripard
2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
2016-06-14 11:17   ` Aleksei Mamlin
2016-06-14 11:17   ` Aleksei Mamlin
2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 12:37     ` Maxime Ripard
2016-06-14 12:37       ` Maxime Ripard
2016-06-14 12:37       ` Maxime Ripard
2016-06-14 11:17   ` [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 12:33     ` Maxime Ripard
2016-06-14 12:33       ` Maxime Ripard
2016-06-14 12:33       ` Maxime Ripard
2016-06-14 11:17   ` [PATCH v2 3/4] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 11:17     ` Aleksei Mamlin
2016-06-14 12:33     ` Maxime Ripard
2016-06-14 12:33       ` Maxime Ripard
2016-06-14 12:33       ` Maxime Ripard
2016-06-14 13:11     ` kbuild test robot
2016-06-14 13:11       ` kbuild test robot
2016-06-14 13:11       ` kbuild test robot
2016-06-14 13:19       ` Aleksei Mamlin
2016-06-14 13:19         ` Aleksei Mamlin
2016-06-14 13:19         ` Aleksei Mamlin
2016-06-14 13:57         ` Maxime Ripard
2016-06-14 13:57           ` Maxime Ripard
2016-06-14 13:57           ` Maxime Ripard
2016-06-14 14:02           ` Aleksei Mamlin
2016-06-14 14:02             ` Aleksei Mamlin
2016-06-14 14:02             ` Aleksei Mamlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606225903.264abc01647eb1528cc226bd@gmail.com \
    --to=mamlinav@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=richard@nod.at \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.