From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: joerg Reisenweber <joerg@openmoko.org>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Pavel Machek <pavel@ucw.cz>,
Nishanth Menon <nm@ti.com>
Subject: Re: Nokia N900: musb is in wrong state after boot
Date: Tue, 7 Jun 2016 14:50:44 +0200 [thread overview]
Message-ID: <20160607125044.GI29844@pali> (raw)
In-Reply-To: <20160529103824.GM29844@pali>
On Sunday 29 May 2016 12:38:24 Pali Rohár wrote:
> > From fd67b58e3538c0732750ecad915cde736da099dc Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
> > Date: Sat, 9 Jan 2016 16:57:59 +0100
> > Subject: [PATCH] musb: debugfs: Add support in testmode for forcing host mode
> > together with speed
> >
> > ---
> > drivers/usb/musb/musb_debugfs.c | 44 +++++++++++++++++++++++++--------------
> > 1 file changed, 28 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c
> > index 9b22d94..62c13a2 100644
> > --- a/drivers/usb/musb/musb_debugfs.c
> > +++ b/drivers/usb/musb/musb_debugfs.c
> > @@ -147,28 +147,34 @@ static int musb_test_mode_show(struct seq_file *s, void *unused)
> >
> > test = musb_readb(musb->mregs, MUSB_TESTMODE);
> >
> > - if (test & MUSB_TEST_FORCE_HOST)
> > + if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS))
> > + seq_printf(s, "force host full-speed\n");
> > +
> > + else if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS))
> > + seq_printf(s, "force host high-speed\n");
> > +
> > + else if (test & MUSB_TEST_FORCE_HOST)
> > seq_printf(s, "force host\n");
> >
> > - if (test & MUSB_TEST_FIFO_ACCESS)
> > + else if (test & MUSB_TEST_FIFO_ACCESS)
> > seq_printf(s, "fifo access\n");
> >
> > - if (test & MUSB_TEST_FORCE_FS)
> > + else if (test & MUSB_TEST_FORCE_FS)
> > seq_printf(s, "force full-speed\n");
> >
> > - if (test & MUSB_TEST_FORCE_HS)
> > + else if (test & MUSB_TEST_FORCE_HS)
> > seq_printf(s, "force high-speed\n");
> >
> > - if (test & MUSB_TEST_PACKET)
> > + else if (test & MUSB_TEST_PACKET)
> > seq_printf(s, "test packet\n");
> >
> > - if (test & MUSB_TEST_K)
> > + else if (test & MUSB_TEST_K)
> > seq_printf(s, "test K\n");
> >
> > - if (test & MUSB_TEST_J)
> > + else if (test & MUSB_TEST_J)
> > seq_printf(s, "test J\n");
> >
> > - if (test & MUSB_TEST_SE0_NAK)
> > + else if (test & MUSB_TEST_SE0_NAK)
> > seq_printf(s, "test SE0 NAK\n");
> >
> > return 0;
> > @@ -206,30 +212,36 @@ static ssize_t musb_test_mode_write(struct file *file,
> > if (copy_from_user(buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
> > return -EFAULT;
> >
> > - if (strstarts(buf, "force host"))
> > + if (strstarts(buf, "force host full-speed"))
> > + test = MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS;
> > +
> > + else if (strstarts(buf, "force host high-speed"))
> > + test = MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS;
> > +
> > + else if (strstarts(buf, "force host"))
> > test = MUSB_TEST_FORCE_HOST;
> >
> > - if (strstarts(buf, "fifo access"))
> > + else if (strstarts(buf, "fifo access"))
> > test = MUSB_TEST_FIFO_ACCESS;
> >
> > - if (strstarts(buf, "force full-speed"))
> > + else if (strstarts(buf, "force full-speed"))
> > test = MUSB_TEST_FORCE_FS;
> >
> > - if (strstarts(buf, "force high-speed"))
> > + else if (strstarts(buf, "force high-speed"))
> > test = MUSB_TEST_FORCE_HS;
> >
> > - if (strstarts(buf, "test packet")) {
> > + else if (strstarts(buf, "test packet")) {
> > test = MUSB_TEST_PACKET;
> > musb_load_testpacket(musb);
> > }
> >
> > - if (strstarts(buf, "test K"))
> > + else if (strstarts(buf, "test K"))
> > test = MUSB_TEST_K;
> >
> > - if (strstarts(buf, "test J"))
> > + else if (strstarts(buf, "test J"))
> > test = MUSB_TEST_J;
> >
> > - if (strstarts(buf, "test SE0 NAK"))
> > + else if (strstarts(buf, "test SE0 NAK"))
> > test = MUSB_TEST_SE0_NAK;
> >
> > musb_writeb(musb->mregs, MUSB_TESTMODE, test);
> > --
> > 1.7.9.5
> >
>
> Tony, what do you think about that patch?
>
Tony, PING
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-06-07 12:50 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 15:16 Nokia N900: musb is in wrong state after boot Pali Rohár
2016-01-09 15:16 ` Pali Rohár
2016-01-19 20:33 ` Tony Lindgren
2016-01-19 20:33 ` Tony Lindgren
2016-01-21 8:40 ` Pali Rohár
2016-01-21 9:57 ` Ivaylo Dimitrov
2016-01-21 10:23 ` Pali Rohár
2016-01-21 10:27 ` Ivaylo Dimitrov
2016-01-21 10:29 ` joerg Reisenweber
2016-01-21 17:41 ` Tony Lindgren
2016-01-21 18:44 ` joerg Reisenweber
2016-01-21 19:21 ` Tony Lindgren
2016-01-21 19:34 ` joerg Reisenweber
2016-01-21 20:30 ` Tony Lindgren
2016-01-26 14:34 ` Pali Rohár
2016-01-26 17:26 ` Tony Lindgren
2016-02-21 11:12 ` Pali Rohár
2016-02-22 7:31 ` Felipe Balbi
2016-02-22 8:34 ` Pali Rohár
2016-02-22 8:54 ` Felipe Balbi
2016-02-22 8:54 ` Felipe Balbi
2016-02-22 15:36 ` Bin Liu
2016-02-22 15:36 ` Bin Liu
2016-02-22 15:49 ` Adam Ford
2016-02-22 15:49 ` Adam Ford
2016-01-23 12:57 ` Pali Rohár
2016-05-29 10:38 ` Pali Rohár
2016-05-29 10:38 ` Pali Rohár
2016-06-07 12:50 ` Pali Rohár [this message]
2016-06-08 9:53 ` Tony Lindgren
2016-06-08 10:02 ` Felipe Balbi
2016-06-08 10:19 ` Pali Rohár
[not found] ` <87h9d49exz.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-06-08 10:20 ` joerg Reisenweber
2016-06-08 10:20 ` joerg Reisenweber
2016-06-08 12:04 ` Sergei Shtylyov
2016-06-08 12:04 ` Sergei Shtylyov
[not found] ` <71cb45ec-a269-d510-df34-eb6eaa781da8-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-08 12:18 ` joerg Reisenweber
2016-06-08 12:18 ` joerg Reisenweber
2016-06-08 12:32 ` Sergei Shtylyov
2016-06-08 12:32 ` Sergei Shtylyov
2016-06-09 21:09 ` Bin Liu
2016-06-09 20:58 ` Bin Liu
2016-06-09 20:58 ` Bin Liu
2016-06-09 21:25 ` joerg Reisenweber
2016-06-09 21:25 ` joerg Reisenweber
2016-06-10 15:08 ` Bin Liu
2016-06-10 15:23 ` joerg Reisenweber
2016-06-10 15:59 ` Bin Liu
2016-06-10 16:15 ` joerg Reisenweber
2016-06-10 17:04 ` Nishanth Menon
[not found] ` <575AF32B.2090705-l0cyMroinI0@public.gmane.org>
2016-06-10 17:21 ` joerg Reisenweber
2016-06-10 17:21 ` joerg Reisenweber
2016-06-10 17:37 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607125044.GI29844@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=joerg@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.