From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V4] syscalls/madvise02: reconstruct and convert to new API
Date: Wed, 8 Jun 2016 11:22:12 +0800 [thread overview]
Message-ID: <20160608032212.GB5008@gmail.com> (raw)
In-Reply-To: <20160607142414.GA4397@rei.lan>
Hi Cyril,
On Tue, Jun 07, 2016 at 04:24:14PM +0200, Cyril Hrubis wrote:
>
> I've moved the setup-like parts from the filter function to setup, so
> that the filter function only filters the testcases.
>
> And also used the LTP_ALIGN() macro to align the tmp_addr and pushed,
> thanks.
Thanks for reviewing. But seems the aligned address is not right, we need
to apply a new patch to fix that.
madvise02: correct the aligned address
Signed-off-by: Li Wang <liwang@redhat.com>
diff --git a/testcases/kernel/syscalls/madvise/madvise02.c b/testcases/kernel/syscalls/madvise/madvise02.c
index 3a595c2..347d9cc 100644
--- a/testcases/kernel/syscalls/madvise/madvise02.c
+++ b/testcases/kernel/syscalls/madvise/madvise02.c
@@ -142,7 +142,7 @@ static void setup(void)
nonalign = file1 + 100;
ptr_addr = SAFE_MALLOC(st.st_size);
- tmp_addr = (void*)LTP_ALIGN((long)tmp_addr, pagesize);
+ tmp_addr = (void*)LTP_ALIGN((long)ptr_addr, pagesize);
SAFE_CLOSE(fd);
Regards,
Li Wang
next prev parent reply other threads:[~2016-06-08 3:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 8:19 [LTP] [PATCH V4] syscalls/madvise02: reconstruct and convert to new API Li Wang
2016-06-07 14:24 ` Cyril Hrubis
2016-06-08 3:22 ` Li Wang [this message]
2016-06-08 9:43 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608032212.GB5008@gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.