From: Ingo Molnar <mingo@kernel.org>
To: "Wanpeng Li" <kernellwp@gmail.com>,
"Rik van Riel" <riel@redhat.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Wanpeng Li" <wanpeng.li@hotmail.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Rik van Riel" <riel@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting
Date: Wed, 8 Jun 2016 09:22:57 +0200 [thread overview]
Message-ID: <20160608072257.GA9612@gmail.com> (raw)
In-Reply-To: <1465355110-21714-3-git-send-email-wanpeng.li@hotmail.com>
* Wanpeng Li <kernellwp@gmail.com> wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> This patch adds guest steal-time support to full dynticks CPU
> time accounting. After the following commit:
>
> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")
>
> ... time sampling became jiffy based, even if it's still listened
> to ring boundaries, so steal_account_process_tick() is reused
> to account how many 'ticks' are stolen-time, after the last accumulation.
So the 'ring boundary' part still doesn't parse (neither grammatically nor
logically) - please rephrase it because I have no idea what you want to say here.
Did you want to say:
> ... time sampling became jiffy based, even if it's still being context tracked,
> so steal_account_process_tick() is reused to account how many 'ticks' are
> stolen-time, after the last accumulation.
... which makes sense grammatically but does not make sense to me logically. :-/
Rik, Frederic, could you please help out?
Thanks,
Ingo
next prev parent reply other threads:[~2016-06-08 7:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 3:05 [PATCH v5 1/3] KVM: fix steal clock warp during guest cpu hotplug Wanpeng Li
2016-06-08 3:05 ` [PATCH v5 2/3] sched/cputime: Fix prev steal time accouting during " Wanpeng Li
2016-06-08 10:01 ` Paolo Bonzini
2016-06-08 10:59 ` Wanpeng Li
2016-06-08 3:05 ` [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting Wanpeng Li
2016-06-08 7:22 ` Ingo Molnar [this message]
2016-06-08 7:27 ` Wanpeng Li
2016-06-08 7:52 ` Ingo Molnar
2016-06-08 8:04 ` Wanpeng Li
2016-06-08 8:12 ` Wanpeng Li
2016-06-08 10:14 ` Paolo Bonzini
2016-06-08 11:11 ` Wanpeng Li
2016-06-13 3:38 ` Wanpeng Li
2016-06-13 7:55 ` Paolo Bonzini
2016-06-13 8:09 ` Wanpeng Li
2016-06-08 19:05 ` Rik van Riel
2016-06-08 23:57 ` Wanpeng Li
2016-06-09 1:20 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608072257.GA9612@gmail.com \
--to=mingo@kernel.org \
--cc=fweisbec@gmail.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.