From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Christian Borntraeger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: fix build failure
Date: Wed, 8 Jun 2016 08:39:29 +0200 [thread overview]
Message-ID: <20160608083929.7268ddf5@mschwide> (raw)
In-Reply-To: <1465336170-23064-1-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, 7 Jun 2016 22:49:30 +0100
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> etr_ptff definitions are moved and renamed but we missed updating them
> here and as a result s390 defconfig and allmodconfig was failing with
> the error:
> arch/s390/kvm/kvm-s390.c:230:45: error: 'ETR_PTFF_QAF' undeclared
>
> Fixes: cc8f94656487 ("s390/time: move PTFF definitions")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> s390 defconfig build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/135776067
>
> arch/s390/kvm/kvm-s390.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index fa51aef..3039eaf 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -29,7 +29,7 @@
> #include <linux/bitmap.h>
> #include <asm/asm-offsets.h>
> #include <asm/lowcore.h>
> -#include <asm/etr.h>
> +#include <asm/timex.h>
> #include <asm/pgtable.h>
> #include <asm/gmap.h>
> #include <asm/nmi.h>
> @@ -227,7 +227,9 @@ static void kvm_s390_cpu_feat_init(void)
> }
>
> if (test_facility(28)) /* TOD-clock steering */
> - etr_ptff(kvm_s390_available_subfunc.ptff, ETR_PTFF_QAF);
> + ptff(kvm_s390_available_subfunc.ptff,
> + sizeof(kvm_s390_available_subfunc.ptff),
> + PTFF_QAF);
>
> if (test_facility(17)) { /* MSA */
> __cpacf_query(CPACF_KMAC, kvm_s390_available_subfunc.kmac);
Already send the exact same patch to Stephen yesterday. But thanks anyway.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2016-06-08 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 21:49 [PATCH] KVM: s390: fix build failure Sudip Mukherjee
2016-06-08 5:17 ` Christian Borntraeger
2016-06-08 5:31 ` Heiko Carstens
2016-06-08 8:09 ` Stephen Rothwell
2016-06-08 10:25 ` Paolo Bonzini
2016-06-08 6:39 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608083929.7268ddf5@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.